ci(postman): test this branch's API code, and unpin the contract workflow - #238
Merged
Merged
Conversation
roncodes
force-pushed
the
ci/contract-overlay-branch-source
branch
from
August 10, 2026 06:57
a09b20f to
05d63aa
Compare
With build-from-source: false the stack boots the published API image, and this package is a composer dependency baked into it — so a PR here booted the released version and ran the collections against that. Its own API changes were never exercised; the check was green on code that was not under review. overlay-package makes the reusable workflow check this repository out at the commit under test and swap it into the running container, dumping the autoloader (the image is built with --optimize-autoloader, so a frozen classmap would otherwise hide classes added or moved on the branch), clearing caches and running migrations. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-v1.6.56 #238 +/- ##
===============================================
Coverage 100.00% 100.00%
Complexity 6716 6716
===============================================
Files 396 396
Lines 22410 22410
===============================================
Hits 22410 22410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line problems, both of which meant this repository's contract check was not testing this repository.
1. It was running an old copy of the workflow
The call was pinned to
fleetbase/fleetbase@dev-v0.7.53, a ref that predates every fix to the contract workflow — including the one where the collections were never actually executing (the step ran for 25ms, produced no output, and passed).Now
@main. The reusable workflow defaultsfleetbase-reftomainand tests againstfleetbase/fleetbase-api:latest, so releases are picked up automatically and there is no ref here to remember to bump. Each run records the resolved image digest in its job summary, so results stay traceable.2. It was testing the published package, not this branch
This is the substantive one. With
build-from-source: falsethe stack boots the published API image, andfleetbase/core-apiis a composer dependency baked into that image. So a PR here booted the released version and ran the collections against it. Its own API changes were never exercised — the check was green on code that was not under review, which is worse than no check because it reads as coverage.overlay-package(fleetbase/fleetbase#582) makes the reusable workflow check this repository out at the commit under test and swap it into the running container. It then dumps the autoloader — necessary, because the image is built with--optimize-autoloaderand the frozen classmap would otherwise hide any class added or moved on the branch — clears caches, runs migrations, and re-checks health so a broken overlay fails loudly.overlay-pathis not needed here: this repository's root is the package root (composer.jsondeclaresfleetbase/core-api).What to expect on the first run
This is the first time these collections will execute against this package's actual branch code, so treat failures as real signal rather than regression. Collection-side fixes landed separately in fleetbase/postman#11, which took the Fleetbase API collection from 85/180 to 129/180 requests returning 2xx.
The overlay has not been exercised end to end anywhere yet — it was verified structurally (vendor layout, package root, the 579-entry frozen classmap, composer availability in the container). This run is its first real test.
🤖 Generated with Claude Code