v0.4.26 - #104
Merged
Merged
Conversation
roncodes
added a commit
that referenced
this pull request
Sep 5, 2026
Seventeen unit tests over the scheduler controller: active and unscheduled orders, the sidebar search and its debounce, the type filter, driver rows and workload bars, the resource-label and event-tile HTML, selection, the view-range mapping, and calendar navigation (including with no calendar attached, which is the state before the template mounts). A unit test rather than a rendering one: the controller only ever talks to @event-calendar/core through setOption/getOption/prev/next, so a stand-in for that API exercises its own logic without pretending to run the calendar. Three findings, recorded not fixed. DEFECTS #102: `driver.max_daily_orders` appears on one line in the whole codebase and is not an attribute, so every capacity bar is measured against 10. #103: the priority filter reads `o.priority`, which OrderModel does not have. #104 (NEEDS DECISION): nothing ever assigns to `activeFilters`, so the filter block never runs at all — which is why #103 is harmless today. scheduler/index.js 0/325 -> 94/325 statements, 0/197 -> 55/197 branches, 0/79 -> 43/79 functions; create-full-calendar-event-from-order.js and to-calendar-date.js now fully covered. Global: statements 7508 -> 7609 (41.00%), branches 4772 -> 4834, functions 2084 -> 2128, lines 7125 -> 7210. Tests 1450 -> 1467; failures unchanged at 81, none new. Lint 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_idproperty to driver resource