add user resource - #105
Closed
doljko wants to merge 1 commit into
Closed
Conversation
roncodes
added a commit
that referenced
this pull request
Sep 5, 2026
Thirty-three tests. The modal block: opening an order, rescheduling from a date or a picker wrapper, saving (success, info when the date is cleared, a straight close when nothing changed, a refusal that keeps the modal open), unscheduling, the shift modal's save and delete including both failures, one-off and recurring shifts (new schedule and reusing an existing one), bulk assign, and the conflict modal's assignAnyway/autoAdjust. Then the residue: four statements were `@tracked` initialisers nothing reads, and thirty branches were sparse-data fallbacks — no id or tracking, no workload, an order answering through get(), a timeline with no inner grid or none at all, an event dragged off every resource row. The last branch is genuinely unreachable — DEFECTS #105. `formatToParts` is built from a literal options object requesting exactly the six types the helper asks for, so the `?? '0'` cannot run. Hoisted into a local const so the pragma attaches, with the trace in the comment. Behaviour unchanged. scheduler/index.js 240/325 -> 326/326 statements, 126/197 -> 195/195 branches, 65/79 -> 79/79 functions, 290/290 lines. Global: statements 7755 -> 7841 (42.25%), branches 4905 -> 4974, functions 2150 -> 2164, lines 7342 -> 7422. Fully covered files 312 -> 313. Tests 1490 -> 1523; failures unchanged at 81, none new. Lint 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.