v0.4.27 - #106
Merged
Merged
Conversation
…er filter for users who do not have a driver profile
roncodes
added a commit
that referenced
this pull request
Sep 5, 2026
Nine tests: markers vs polygons on registration, re-centring on user.located, the service-area menu's blur/create-zone/edit-boundaries callbacks (and edit-boundaries correctly absent on Google Maps), the zone menu's boundary editing, a zone in a plain array removed through `set`, and loadResource's onLoaded/onFailure options — no in-repo caller, but reachable through the component published on the universe, so covered as an extension would. DEFECTS #106: `#getValidLatitude` and `#getValidLongitude` each appear exactly once — their own declarations — and are never called. The constructor reads `location.getLatitude()` raw, while the line above it wires the sibling `getValidZoom()`. A NaN or out-of-range coordinate reaches Leaflet as the map centre and the fallback is dead. Two lines would fix it, but that is a behaviour change; recorded, pragma'd with the trace, and the test pins current behaviour so the fix has an assertion to update. leaflet-live-map.js 296/345 -> 304/345 statements, 134/201 -> 141/201 branches, 53/70 -> 57/70 functions. Global: statements 8091 -> 8099 (43.64%), branches 5094 -> 5101, functions 2211 -> 2215, lines 7661 -> 7669. Tests 1569 -> 1578; failures unchanged at 80, none new. Lint 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.