Skip to content

Fix live fleet map settings render-time mutation - #314

Merged
roncodes merged 1 commit into
release/v0.6.62from
feature/fix-live-fleet-map-settings-load
Sep 6, 2026
Merged

Fix live fleet map settings render-time mutation#314
roncodes merged 1 commit into
release/v0.6.62from
feature/fix-live-fleet-map-settings-load

Conversation

@roncodes

@roncodes roncodes commented Sep 6, 2026

Copy link
Copy Markdown
Member

Summary

  • keep the map settings in-flight request promise as internal, non-rendered state
  • prevent Ember from dirtying the tracked loadPromise tag after it is read during live-fleet widget construction
  • resolve the runtime assertion that prevented the live fleet widget from rendering

Verification

Lint and tests were intentionally not run while the reported local runtime errors are being cleared. The change is isolated to addon/services/map-settings.js.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (71e2e8a) to head (116d8aa).
⚠️ Report is 13 commits behind head on release/v0.6.62.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/v0.6.62      #314    +/-   ##
====================================================
  Coverage             100.00%   100.00%            
- Complexity              9899     10003   +104     
====================================================
  Files                    526       531     +5     
  Lines                  38163     38585   +422     
====================================================
+ Hits                   38163     38585   +422     
Flag Coverage Δ
backend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roncodes
roncodes merged commit 131b5a6 into release/v0.6.62 Sep 6, 2026
8 checks passed
@roncodes
roncodes deleted the feature/fix-live-fleet-map-settings-load branch September 6, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant