Remove unused context component utilities and imported from ember-core - #91
Merged
Conversation
roncodes
added a commit
that referenced
this pull request
Sep 4, 2026
Builds the yielding LeafletMap stand-in — it yields (hash tile= marker=) and the marker yields (hash popup= tooltip=), matching ember-leaflet's shape, with div-icon/icon/point-to-coordinates registered as helpers that hand back their named args. That unlocked the half of the template that had never rendered. Ten tests: order stops pinned as P/D badges with popups and tooltips; a multi-drop order pinned per waypoint in its own order, with 0,0 dropped; _placeCoords across the shapes it accepts and three it does not; a driver pinned with their status; several stops fitted as a box and one zoomed to; the browser location centring the map, arriving late and being ignored, and being refused; a plan's A1/A2/B stop labels; and a driver matched to a group by vehicle_id. Three selection getters were deleted rather than covered (DEFECTS #91) — the callers a grep appears to find are the sub-components' own identically-named getters, and the workbench template never reads them. orchestrator-workbench.js 377/428 -> 409/425 stmts, 174/261 -> 223/261 branches, 84/94 -> 91/91 functions (all of them) Totals statements 6788 -> 6820 (36.73%) branches 4413 -> 4462 (37.10%) functions 1941 -> 1948 lines 6430 -> 6458 Tests 1373 -> 1383, passing 1290 -> 1300; failures unchanged at 83.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyContextComponentArguments,contextComponentCallbackfunctions moved toember-corefor shared usage.