hotfix: TrackOrderDistanceAndTime command so that it only pulls orders created in t he last month and explicilty uses a provider - #98
Merged
Conversation
…orders created in the last month and explicilty uses a provider
roncodes
added a commit
that referenced
this pull request
Sep 5, 2026
Seven tests over `restoreFromServiceQuote` and the item surface it unlocks. The restore path is the only way a *saved* entity reaches `this.entities` (`addEntity` only ever createRecords), so `removeEntity`'s destroyRecord arm and `editEntity`'s immediate-upload arm had to come with it rather than as a separate batch. Found while writing the harness — DEFECTS #98: `confirm` replays a new item's held-back photo with `modal.invoke('uploadNewPhoto', pendingFileUpload)`, but `invoke`'s second positional is `modalId`, so no modal is found and the callback never runs. The photo is silently dropped. Recorded, not fixed; the test asserts current behaviour and names the entry. create-order-form.js 249/395 -> 301/395 statements, 99/197 -> 127/197 branches, 40/67 -> 48/67 functions. Global: statements 7066 -> 7118 (38.36%), branches 4592 -> 4620, functions 1988 -> 1996, lines 6693 -> 6744. Tests 1421 -> 1428; failures unchanged at 82, none new. Lint 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrackOrderDistanceAndTimecommand so that it only pulls orders created in the last month and explicilty uses a provider