Skip to content

Fix cash pickup checkout without delivery quote - #93

Merged
roncodes merged 1 commit into
dev-v0.4.20from
fix/cash-pickup-checkout
Aug 30, 2026
Merged

Fix cash pickup checkout without delivery quote#93
roncodes merged 1 commit into
dev-v0.4.20from
fix/cash-pickup-checkout

Conversation

@roncodes

Copy link
Copy Markdown
Member

Summary

  • allow cash checkout initialization to receive no delivery service quote
  • persist a null service quote for pickup while preserving subtotal and cash-on-delivery state
  • add a regression test for cash pickup without a delivery quote

Verification

  • complete Storefront server unit suite passes
  • checkout boundary suite: 47 tests, 272 assertions
  • PHP-CS-Fixer reports no changes
  • git diff check passes

API and review notes

This aligns the implementation with the existing pickup checkout contract and does not add request fields. Cash checkout behavior requires human review before merge.

Static analysis baseline

The repository type command is currently blocked by its existing configuration and the touched controller has extensive pre-existing PHPStan findings. This PR does not expand scope into that baseline cleanup.

@roncodes roncodes added type:bug Bug fix priority:p1 High priority needs-human-review Requires human review before proceeding labels Aug 30, 2026
@roncodes
roncodes merged commit 4c06110 into dev-v0.4.20 Aug 30, 2026
@roncodes
roncodes deleted the fix/cash-pickup-checkout branch August 30, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human-review Requires human review before proceeding priority:p1 High priority type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant