ci(release): adopt the release/v* branch convention - #97
Conversation
Both prefixes are honoured so a release branch opened before the rename still releases. A merge that produces no tag and no publish looks exactly like a successful one, so the cutover is deliberately not a flag day.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1775 1775
===========================================
Files 135 135
Lines 7785 7785
===========================================
Hits 7785 7785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cuts the patch release carrying the QPay authentication fix (#99) and the network model repairs and testing seeder split (#98). The release/v* workflow gate is deliberately NOT changed here — #97 owns that, with fleetbase/fleetbase#641 behind it. Both must land before this branch is merged, or the tag job either skips (old gate) or is refused by the reusable workflow (gate updated, reusable workflow not yet).
|
Reviewed this against the live workflows — the change here is correct, but merging it alone won't enable the convention, and there was a conflict with the v0.4.21 release branch that I've now removed. 1. The real blocker is fleetbase/fleetbase#641, still open. The reusable workflow this delegates to at if [[ "$HEAD_REF" != dev-v* ]]; then
echo "::error::Head branch '${HEAD_REF}' is not a dev-v* release branch."So with this PR merged and #641 not, a 2. Conflict with #100, resolved on my side. The v0.4.21 release branch had briefly carried the same gate change, which conflicted with this PR (verified by test-merge: 3. Nothing else in this repo assumes Order to unblock the v0.4.21 release: fleetbase/fleetbase#641 → this → #99 and #98 into |
Adopts the
release/v0.0.0branch convention. Companion to fleetbase/fleetbase#641, which holds the reusable workflow this delegates to.What changed
One line, so the caller matches either prefix:
Why both, rather than a cutover
A hard switch would leave any release branch already open unrecognised — and a merge that produces no tag and no publish looks exactly like a successful one.
dev-v*keeps working; drop that arm once no such branch remains open.Merge order
fleetbase/fleetbase#641 first. This caller references the reusable workflow at
@main, sorelease/v*only starts being accepted once that lands. Merging this one early is harmless — it just keeps behaving as it does today.🤖 Generated with Claude Code