Skip to content

There is no size limitation on the software icon upload #32826

@AndreyKizimenko

Description

@AndreyKizimenko

Fleet version: 4.74

Web browser and operating system: N/A


💥  Actual behavior

You can upload an icon of any size, which affects the icon render time, which can go over 3 seconds

Image

🛠️ To fix

From @noahtalerman here: #29478 (comment)

I think it’s a great idea to add a limit to the size. With an easy to understand error message if you try to upload one that’s too large. 100kb sounds like the right size to start. I just exported the Firefox logo from Figma and it was ~4kb.

Product designer: _________________________

🧑‍💻  Steps to reproduce

  1. Have an icon that matches the dimensions requirements but is very large in size
  2. Try to upload it as a software icon
  3. Refresh the page and notice the render time

🕯️ More info (optional)

N/A

Metadata

Metadata

Assignees

Labels

#g-softwareSoftware product group:releaseReady to write code. Scheduled in a release. See "Making changes" in handbook.bugSomething isn't working as documented~unreleased bugThis bug was found in an unreleased version of Fleet.

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions