Skip to content

restricting icon size to 100kb.#32834

Merged
ksykulev merged 2 commits intomainfrom
32826-icon-size
Sep 10, 2025
Merged

restricting icon size to 100kb.#32834
ksykulev merged 2 commits intomainfrom
32826-icon-size

Conversation

@ksykulev
Copy link
Copy Markdown
Contributor

@ksykulev ksykulev commented Sep 10, 2025

fixes #32826

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

@ksykulev
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-09-10 at 5 59 17 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.80%. Comparing base (db0b92f) to head (eca34e0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/service/software_title_icons.go 59.09% 6 Missing and 3 partials ⚠️
...reTitleDetailsPage/EditIconModal/EditIconModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32834      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files        2040     2040              
  Lines      201163   201181      +18     
  Branches     6644     6681      +37     
==========================================
+ Hits       128363   128371       +8     
- Misses      62650    62656       +6     
- Partials    10150    10154       +4     
Flag Coverage Δ
backend 64.99% <59.09%> (-0.01%) ⬇️
frontend 52.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to merge.

@ksykulev ksykulev merged commit e2fd468 into main Sep 10, 2025
35 checks passed
@ksykulev ksykulev deleted the 32826-icon-size branch September 10, 2025 23:25
ksykulev added a commit that referenced this pull request Sep 10, 2025
fixes #32826

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
- [x] Alerted the release DRI if additional load testing is needed
iansltx pushed a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no size limitation on the software icon upload

2 participants