UI - add padding to my device page#16287
Merged
RachelElysia merged 2 commits intomainfrom Jan 23, 2024
Merged
Conversation
jacobshandling
had a problem deploying
to
Docker Hub
GitHub Actions
Error
lukeheath
previously approved these changes
Jan 23, 2024
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16287 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 1124 1124
Lines 97575 97575
Branches 2413 2413
=======================================
Hits 63868 63868
Misses 28925 28925
Partials 4782 4782
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
approved these changes
Jan 23, 2024
lukeheath
pushed a commit
that referenced
this pull request
Jan 23, 2024
1 task
jacobshandling
added a commit
that referenced
this pull request
Jan 25, 2024
…-wrapper` and `.main-content` to DUP (#16310) ## More global solution to #16277, cleanup to prevent similar bugs - Swap out [localized solution](#16287) for standard `.main-content` containing desired padding - Apply `.core-wrapper` class to parent, in line with all other UI pages - Remove problematic legacy `.body-wrap` - spot check all places this class was being applied: - PlatformWrapper - LiveQuery –> SelectTargets (was causing excess padding here) - PackQueriesTable (caused excess padding here) - TeamManagementPage (excess padding was being locally negated) - EditQueryPage - LiveQueryPage - DeviceUserPage - Remove local styles meant to negate `.body-wrap`'s styles - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16277
Checklist for submitter
changes/