UI – remove problematic legacy .body-wrap, apply UI-standard .core-wrapper and .main-content to DUP#16310
Merged
jacobshandling merged 2 commits intomainfrom Jan 25, 2024
Merged
Conversation
- Spot check all places this class was being applied:
- PlatformWrapper
- LiveQuery –> SelectTargets (was causing excess padding here)
- PackQueriesTable (caused excess padding here)
- TeamManagementPage (excess padding was being locally nullified)
- EditQueryPage
- LiveQueryPage
- DeviceUserPage (see next commit)
- Remove local styles meant to nullify `.body-wrap`s styles
- Swap out localized solution for standardized `main-content` class containing desired padding - Apply `.core-wrapper` class to parent, in line with all other UI pages
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
changed the title
.body-wrap; apply standard .core-wrapper and .main-content to DUP.body-wrap, apply UI-standard .core-wrapper and .main-content to DUP
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16310 +/- ##
=======================================
Coverage 65.45% 65.46%
=======================================
Files 1124 1124
Lines 97575 97575
Branches 2413 2413
=======================================
+ Hits 63868 63875 +7
+ Misses 28925 28918 -7
Partials 4782 4782
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
changed the title
.body-wrap, apply UI-standard .core-wrapper and .main-content to DUP.body-wrap, apply UI-standard .core-wrapper and .main-content to DUP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More global solution to #16277, cleanup to prevent similar bugs
Swap out localized solution for standard
.main-contentcontaining desired paddingApply
.core-wrapperclass to parent, in line with all other UI pagesRemove problematic legacy
.body-wrap.body-wrap's stylesManual QA for all new/changed functionality