Return 0 count for team vulnerability#16897
Merged
Merged
Conversation
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 15919-vulnerabilities-page #16897 +/- ##
=============================================================
Coverage ? 66.11%
=============================================================
Files ? 1148
Lines ? 101987
Branches ? 2525
=============================================================
Hits ? 67427
Misses ? 29559
Partials ? 5001
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
force-pushed
the
16891-api-empty-states
branch
from
59aa66d to
cab01a2
Compare
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Error
mostlikelee
changed the base branch from
15919-vulnerabilities-page
to
victor/15919-team-filter
mostlikelee
commented
Feb 17, 2024
| LEFT JOIN vulnerability_host_counts vhc ON cm.cve = vhc.cve | ||
| ` | ||
|
|
||
| freeSelectStmt := ` |
Contributor
Author
There was a problem hiding this comment.
updating this statement because the cve_meta table is not populated on Fleet free
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
changed the base branch from
victor/15919-team-filter
to
15919-vulnerabilities-page
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
getvictor
approved these changes
Feb 20, 2024
| osvs, err := ds.OSVersions(ctx, teamID, nil, nil, nil) | ||
| if err != nil { | ||
| return nil, updatedAt, ctxerr.Wrap(ctx, err, "fetching OS versions by CVE") | ||
| if err != nil && !fleet.IsNotFound(err) { |
Member
There was a problem hiding this comment.
if teamID == null, you should exit with error here
getvictor
added a commit
that referenced
this pull request
Feb 20, 2024
#16906 **IN DRAFT, WAITING ON #16897 - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] Manual QA for all new/changed functionality --------- Co-authored-by: Victor Lyuboslavsky <victor@fleetdm.com> Co-authored-by: Victor Lyuboslavsky <victor.lyuboslavsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16891
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)