Skip to content

Pluralize hosts_count#16907

Merged
getvictor merged 29 commits into
15919-vulnerabilities-pagefrom
16906-pluralize
Feb 20, 2024
Merged

Pluralize hosts_count#16907
getvictor merged 29 commits into
15919-vulnerabilities-pagefrom
16906-pluralize

Conversation

@mostlikelee
Copy link
Copy Markdown
Contributor

#16906

IN DRAFT, WAITING ON #16897

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (15919-vulnerabilities-page@8cb6722). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             15919-vulnerabilities-page   #16907   +/-   ##
=============================================================
  Coverage                              ?   66.11%           
=============================================================
  Files                                 ?     1148           
  Lines                                 ?   101987           
  Branches                              ?     2525           
=============================================================
  Hits                                  ?    67427           
  Misses                                ?    29559           
  Partials                              ?     5001           
Flag Coverage Δ
backend 67.22% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getvictor getvictor marked this pull request as ready for review February 20, 2024 15:51
@getvictor getvictor requested a review from a team as a code owner February 20, 2024 15:51
Copy link
Copy Markdown
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getvictor getvictor merged commit 9ed0c19 into 15919-vulnerabilities-page Feb 20, 2024
@getvictor getvictor deleted the 16906-pluralize branch February 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants