to RC: UI: Coordinate sibling refetches via parent state (#20973)#21011
Merged
jacobshandling merged 1 commit intominor-fleet-v4.55.0from Aug 2, 2024
Merged
to RC: UI: Coordinate sibling refetches via parent state (#20973)#21011jacobshandling merged 1 commit intominor-fleet-v4.55.0from
jacobshandling merged 1 commit intominor-fleet-v4.55.0from
Conversation
## #20965 https://www.loom.com/share/52ff44615e2e41a99c129acd3d2427bf?sid=f90ead66-9730-4538-95db-a70bf971b5a8 - [x] Manual QA for all new/changed functionality) --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
RachelElysia
approved these changes
Aug 2, 2024
gillespi314
approved these changes
Aug 2, 2024
| orderDirection, | ||
| orderKey, | ||
| teamId, | ||
| addedSoftwareToken, |
Contributor
There was a problem hiding this comment.
Nice! I was hoping this was going to be the solution you found :)
A couple small comments for future consideration:
Are we including this new field in the URL params? If so, can we omit it, like we do for scope on line 90 below?
It might be nice to establish a pattern for this approach more generally. Perhaps addedSoftwareToken could become something more generic like refetchAt.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR already merged to
main, see #20973. This is against the release branch so it can be included in 4.55.0