Conversation
> [!NOTE] > This the commits in this PR already merged in `main`. This is against the release branch so it can be included in 4.55.0
> [!NOTE] > This the commits in this PR already merged in `main`. This is against the release branch so it can be included in 4.55.0 --------- Co-authored-by: Dante Catalfamo <43040593+dantecatalfamo@users.noreply.github.com>
> [!NOTE] > This code was already merged to main here: #21010. This is just a backport into the RC branch > Related issue: #20978 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Manual QA for all new/changed functionality
Cherry pick for #20986 to 4.55.0 minor branch. Co-authored-by: Tim Lee <timlee@fleetdm.com>
> Related issue: #21030 Original PR at https://github.com/fleetdm/fleet/pull/21031/files Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com> Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
roperzh
requested review from
a team,
georgekarrv,
getvictor,
gillespi314,
jacobshandling,
lucasmrod,
lukeheath,
mostlikelee and
sharon-fdm
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor-fleet-v4.55.0(Cherry pick for #20994 tominor-fleet-v4.55.0#21051)minor-fleet-v4.55.0(Cherry pick #20464 tominor-fleet-v4.55.0#21054)