Conversation
gillespi314
reviewed
Aug 3, 2024
server/datastore/mysql/migrations/tables/20240802113716_UpdateSoftwareGitopsConfig.go
Outdated
Show resolved
Hide resolved
roperzh
previously approved these changes
Aug 3, 2024
Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
gillespi314
previously approved these changes
Aug 3, 2024
Contributor
|
@jahzielv seems like there's a lint error |
Contributor
Author
|
@roperzh yep fixed! |
roperzh
approved these changes
Aug 3, 2024
gillespi314
approved these changes
Aug 3, 2024
roperzh
approved these changes
Aug 5, 2024
roperzh
pushed a commit
that referenced
this pull request
Aug 5, 2024
> Related issue: #21030 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
roperzh
added a commit
that referenced
this pull request
Aug 5, 2024
> Related issue: #21030 Original PR at https://github.com/fleetdm/fleet/pull/21031/files Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com> Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)