UI – Update empty Software versions table when installable software present#21118
UI – Update empty Software versions table when installable software present#21118jacobshandling merged 4 commits intomainfrom
Conversation
- When no versions, add additional call for software titles available install to know when to display this copy
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
ghernandez345
left a comment
ghernandez345
left a comment
There was a problem hiding this comment.
This looks good. It would be good to try to have some tests around this component as the content on this page the user sees seems quite dynamic. It would be good to have some tests to ensure we are rendering the correct content depending on what the API is sending back and so that we don't break the current functionality in the future if we make more changes to this page.
Feel free to add these in a separate PR. happy to pair together on these also if you'd like
RachelElysia
left a comment
RachelElysia
left a comment
There was a problem hiding this comment.
Thanks for taking this. Same what Gabe said, we should get tests around this sooner than later, maybe create another ticket on endpoint ops board for transparency.
|
Sounds good, will add tests in follow-up PR – merging to get the release out the door |
…resent (#21118) ## Addresses 1a of #21053 <img width="1498" alt="Screenshot 2024-08-06 at 7 56 38 PM" src="https://github.com/user-attachments/assets/d2e97e07-acd7-4f0b-a609-b8b9546a742d"> - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
3 participants
Addresses 1a of #21053