Bugfix: re-create deleted iOS/iPadOS host entries in Fleet if it checks in again via MDM#27231
Bugfix: re-create deleted iOS/iPadOS host entries in Fleet if it checks in again via MDM#27231
Conversation
mna
force-pushed
the
mna-22941-revive-deleted-byob-iphone
branch
from
9bd4d9a to
7a59e54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27231 +/- ##
==========================================
- Coverage 63.78% 63.77% -0.01%
==========================================
Files 1744 1745 +1
Lines 165612 165804 +192
Branches 4515 4570 +55
==========================================
+ Hits 105630 105745 +115
- Misses 51750 51808 +58
- Partials 8232 8251 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/service/apple_mdm.go
Outdated
| // TODO(iosrevive): (optional), if we want to go out of our way to re-create | ||
| // the deleted iDevices ASAP, we could include them in the list of hosts to | ||
| // send a push to, so that they checkin early (it can be arbitrarily long | ||
| // without a push notification). |
There was a problem hiding this comment.
Pending product decision (asked on Slack here: https://fleetdm.slack.com/archives/C03C41L5YEL/p1742413143321909)
There was a problem hiding this comment.
Seems like we want it so I'll add to this PR next week to finish this up.
| @@ -0,0 +1 @@ | |||
| * Fixed a bug where BYOD iDevices deleted in Fleet but still enrolled in MDM were not re-created on the next MDM checkin. | |||
There was a problem hiding this comment.
(not mentioning ABM/ADE devices since it was already working, I just added a test to cover this scenario)
2 participants
For #22941 and #22391
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).See: ABM iPhone not re-enrolling after being deleted from Fleet #22391 (comment) and BYOD iPhone deleted in Fleet never re-appears even though it's still enrolled #22941 (comment)