Regen mocks and use the new func names#35655
Merged
Merged
Conversation
JordanMontgomery
had a problem deploying
to
Docker Hub
GitHub Actions
Error
JordanMontgomery
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35655 +/- ##
==========================================
+ Coverage 66.22% 66.25% +0.02%
==========================================
Files 2104 2104
Lines 178300 178300
Branches 7288 7288
==========================================
+ Hits 118072 118124 +52
+ Misses 49412 49357 -55
- Partials 10816 10819 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
approved these changes
Nov 12, 2025
Contributor
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
LGTM. We definitely need a CI job to catch this before a PR gets merged.
JordanMontgomery
added a commit
that referenced
this pull request
Nov 17, 2025
See https://github.com/fleetdm/fleet/actions/runs/19313106183/job/55238111566?pr=35663 for an example of what this looks like when it fails See #35655 for why we need this. Someone was able to check in code that inadvertently broke things for other developers. This is similar to why we have the existing "DB" tests that validate you updated the DB Schema file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Related to #35357
No functional changes - regens mocks for #35572
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing