Skip to content

Add test to validate mock changes#35663

Merged
JordanMontgomery merged 2 commits into
mainfrom
JM-test-mocks
Nov 17, 2025
Merged

Add test to validate mock changes#35663
JordanMontgomery merged 2 commits into
mainfrom
JM-test-mocks

Conversation

@JordanMontgomery
Copy link
Copy Markdown
Member

@JordanMontgomery JordanMontgomery commented Nov 12, 2025

See https://github.com/fleetdm/fleet/actions/runs/19313106183/job/55238111566?pr=35663 for an example of what this looks like when it fails

See #35655 for why we need this. Someone was able to check in code that inadvertently broke things for other developers. This is similar to why we have the existing "DB" tests that validate you updated the DB Schema file

@JordanMontgomery JordanMontgomery changed the title Add test to validate mock changes Draft: Add test to validate mock changes Nov 12, 2025
@JordanMontgomery JordanMontgomery marked this pull request as ready for review November 12, 2025 22:05
@JordanMontgomery JordanMontgomery changed the title Draft: Add test to validate mock changes Add test to validate mock changes Nov 12, 2025
@JordanMontgomery JordanMontgomery merged commit ea55149 into main Nov 17, 2025
5 checks passed
@JordanMontgomery JordanMontgomery deleted the JM-test-mocks branch November 17, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants