Skip to content

Rename teams and queries to fleets and reports in UI#39572

Merged
lukeheath merged 27 commits intomainfrom
39329-rename-teams-to-fleets-frontend
Feb 17, 2026
Merged

Rename teams and queries to fleets and reports in UI#39572
lukeheath merged 27 commits intomainfrom
39329-rename-teams-to-fleets-frontend

Conversation

@sgress454
Copy link
Copy Markdown
Contributor

This is a branch to work through changing:

  • team -> fleet
  • teams -> fleets
  • query -> report
  • queries -> reports

where appropriate.

The changes will be deployed to https://fleet-xfgo.onrender.com/, with the user/pass in 1password under "First Impressions Render instance".

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Feb 16, 2026

Code Review Summary

Status: 6 Issues Found | Recommendation: Address before merge

Fix these issues in Kilo Cloud

Overview

Severity Count
CRITICAL 1
WARNING 4
SUGGESTION 1

Hello, neighbor. I've taken a careful look through this PR — it's a big one, with 193 files touched! The rename from teamfleet in UI text, team_idfleet_id in URL query params, and queryreport in user-facing strings is largely consistent and well-executed. I do want to share a few things I noticed that I think would be worth addressing.

Issue Details (click to expand)

CRITICAL

File Line Issue
frontend/pages/admin/UserManagementPage/components/UsersTable/UsersTableConfig.tsx (inline) Accessor renamed to "fleets" but the data property from the API is still teams — this will cause the column to render empty

WARNING

File Line Issue
frontend/pages/queries/edit/components/SaveAsNewQueryModal/SaveAsNewQueryModal.tsx (inline) Missed team_idfleet_id rename for URL query param
frontend/utilities/constants.tsx (inline) Unused import — upperFirst is imported but never used
frontend/pages/queries/edit/components/ConfirmSaveChangesModal/ConfirmSaveChangesModal.tsx (inline) Confusing wording after rename
frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx (inline) Unused import — upperFirst is imported but never used

SUGGESTION

File Line Issue
frontend/utilities/helpers.tsx (inline) Dead string — "No fleet" is never produced by the code
Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File Line Issue
frontend/hooks/useTeamIdParam.ts 143-146 WARNING: Pre-existing logic bug in rebuildQueryStringWithTeamId — the condition if (paramIndex === -1) on line 143 calls parts.splice(-1, 1, newPart) which replaces the last array element instead of appending. The else branch on line 145-146 pushes when the param is found, which adds a duplicate instead of replacing. The branches appear swapped. Not introduced by this PR but worth noting.
frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAddPage.tsx 86 SUGGESTION: Code comment still says "No team" context — could be updated to "Unassigned" for consistency with the new terminology, though this is non-functional.
Files Reviewed (193 files)

This PR touches 193 files across the frontend codebase. The changes fall into three main categories:

  1. URL query param rename: team_idfleet_id across all route/navigation code
  2. UI text rename: "team" → "fleet" in user-facing strings
  3. UI text rename: "query" → "report" in user-facing strings
  4. UI text rename: "No team" → "Unassigned" in user-facing strings

The useTeamIdParam hook includes thoughtful backward compatibility — it detects legacy team_id= URL params and rewrites them to fleet_id=, which is a nice touch for bookmarked URLs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 42.37288% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.28%. Comparing base (fc31741) to head (cb88b5a).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
frontend/hooks/useTeamIdParam.ts 0.00% 14 Missing ⚠️
...vityFeed/GlobalActivityItem/GlobalActivityItem.tsx 66.66% 12 Missing ⚠️
...es/queries/ManageQueriesPage/ManageQueriesPage.tsx 0.00% 7 Missing ⚠️
...onents/SaveAsNewQueryModal/SaveAsNewQueryModal.tsx 0.00% 5 Missing ⚠️
frontend/utilities/helpers.tsx 16.66% 5 Missing ⚠️
.../hosts/details/HostDetailsPage/HostDetailsPage.tsx 0.00% 4 Missing ⚠️
frontend/router/paths.ts 0.00% 4 Missing ⚠️
...ntend/components/top_nav/SiteTopNav/SiteTopNav.tsx 0.00% 2 Missing ⚠️
.../cards/HostSoftwareLibrary/HostSoftwareLibrary.tsx 0.00% 2 Missing ⚠️
...policies/ManagePoliciesPage/ManagePoliciesPage.tsx 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #39572   +/-   ##
=======================================
  Coverage   66.27%   66.28%           
=======================================
  Files        2439     2439           
  Lines      195401   195393    -8     
  Branches     8615     8608    -7     
=======================================
  Hits       129511   129511           
+ Misses      54160    54152    -8     
  Partials    11730    11730           
Flag Coverage Δ
frontend 54.14% <42.37%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…/ConfirmSaveChangesModal.tsx

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Comment thread frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx Outdated
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
…UsersTableConfig.tsx

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@lukeheath
Copy link
Copy Markdown
Member

@kiloconnect review

@lukeheath lukeheath changed the title Rename terms in front end Rename teams and queries to fleets and reports in UI Feb 17, 2026
@lukeheath
Copy link
Copy Markdown
Member

@CodeRabbit-ai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 17, 2026

@lukeheath: I'll conduct a full review of the PR changes, examining the renaming of teams → fleets and queries → reports throughout the codebase.

✅ Actions performed

Full review triggered.

Comment thread frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx Outdated
…usinessManagerPage/components/EditTeamsAbmModal/EditTeamsAbmModal.tsx
@lukeheath lukeheath merged commit cd18ced into main Feb 17, 2026
17 checks passed
@lukeheath lukeheath deleted the 39329-rename-teams-to-fleets-frontend branch February 17, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants