Skip to content

FMA version rollback#40038

Merged
jahzielv merged 12 commits intomainfrom
31919-rollback
Feb 24, 2026
Merged

FMA version rollback#40038
jahzielv merged 12 commits intomainfrom
31919-rollback

Conversation

@jahzielv
Copy link
Copy Markdown
Contributor

@jahzielv jahzielv commented Feb 18, 2026

Related issue: Resolves #31919

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

jkatz01 and others added 8 commits February 9, 2026 17:37
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #38768 

## Testing

- [x] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #38770 Resolves #38771 Resolves #38769

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
@jahzielv jahzielv marked this pull request as ready for review February 18, 2026 17:57
@jahzielv jahzielv requested review from a team as code owners February 18, 2026 17:57
@fleetdm fleetdm deleted a comment from coderabbitai Bot Feb 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 66.92913% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.34%. Comparing base (0130848) to head (62cd2ec).
⚠️ Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
...ePage/components/forms/PackageForm/PackageForm.tsx 2.04% 48 Missing ⚠️
server/datastore/mysql/software_installers.go 85.71% 8 Missing and 7 partials ⚠️
server/datastore/mysql/software_titles.go 82.75% 8 Missing and 7 partials ⚠️
ee/server/service/software_installers.go 64.28% 5 Missing and 5 partials ⚠️
...mponents/forms/SoftwareVppForm/SoftwareVppForm.tsx 0.00% 9 Missing ⚠️
...tions/tables/20260218175704_FMAActiveInstallers.go 66.66% 4 Missing and 2 partials ⚠️
frontend/hooks/useSoftwareInstallerMeta.ts 37.50% 5 Missing ⚠️
...twarePage/components/forms/PackageForm/helpers.tsx 16.66% 5 Missing ⚠️
...lsPage/FleetAppDetailsForm/FleetAppDetailsForm.tsx 0.00% 4 Missing ⚠️
frontend/components/FileDetails/FileDetails.tsx 25.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40038      +/-   ##
==========================================
+ Coverage   66.31%   66.34%   +0.02%     
==========================================
  Files        2453     2458       +5     
  Lines      196616   197295     +679     
  Branches     8590     8735     +145     
==========================================
+ Hits       130384   130891     +507     
- Misses      54420    54558     +138     
- Partials    11812    11846      +34     
Flag Coverage Δ
backend 68.15% <81.25%> (+0.04%) ⬆️
frontend 54.12% <31.19%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread server/datastore/mysql/software_titles.go
Comment thread server/service/integration_enterprise_test.go
cdcme
cdcme previously approved these changes Feb 23, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** no issue, various feedback items for #31919 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
@jahzielv
Copy link
Copy Markdown
Contributor Author

addressed above comments here: #40319

cdcme
cdcme previously approved these changes Feb 24, 2026
@jahzielv jahzielv merged commit ac4ec2f into main Feb 24, 2026
44 checks passed
@jahzielv jahzielv deleted the 31919-rollback branch February 24, 2026 19:00
jahzielv added a commit that referenced this pull request Feb 24, 2026
- **Gitops specify FMA rollback version (#39582)**
- **Fleet UI: Show versions options for FMA installers (#39583)**
- **rollback: DB and core implementation (#39650)**

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #31919 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)
- [x] QA'd all new/changed functionality manually

---------

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Carlo DiCelico <carlo@fleetdm.com>
jahzielv added a commit that referenced this pull request Feb 24, 2026
cherry-pick for #40038

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Carlo DiCelico <carlo@fleetdm.com>
color: $ui-fleet-black-50;
}

input {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source of #40602

@georgekarrv georgekarrv mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollback Fleet-maintained apps to previous version via GitOps

4 participants