Skip to content

Followup for enforcing manual agent install restrictions in gitops#40503

Merged
jkatz01 merged 3 commits intomainfrom
40412-gitops-setup-experience-restrictions-followup
Feb 25, 2026
Merged

Followup for enforcing manual agent install restrictions in gitops#40503
jkatz01 merged 3 commits intomainfrom
40412-gitops-setup-experience-restrictions-followup

Conversation

@jkatz01
Copy link
Copy Markdown
Member

@jkatz01 jkatz01 commented Feb 25, 2026

Related issue: Resolves #40412

Testing

  • Added/updated automated tests

  • Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)

  • QA'd all new/changed functionality manually

  • Individually or together setting vpp, software installers, or fleet maintained apps will send the correct error now when applied to no team with manual_agent_install enabled.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.27%. Comparing base (adeec0a) to head (e4b3eb4).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40503   +/-   ##
=======================================
  Coverage   66.26%   66.27%           
=======================================
  Files        2461     2461           
  Lines      197427   197435    +8     
  Branches     8655     8655           
=======================================
+ Hits       130832   130845   +13     
+ Misses      54749    54742    -7     
- Partials    11846    11848    +2     
Flag Coverage Δ
backend 68.14% <53.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01 jkatz01 marked this pull request as ready for review February 25, 2026 17:28
@jkatz01 jkatz01 requested a review from a team as a code owner February 25, 2026 17:28
@jkatz01 jkatz01 merged commit 60152ba into main Feb 25, 2026
70 of 73 checks passed
@jkatz01 jkatz01 deleted the 40412-gitops-setup-experience-restrictions-followup branch February 25, 2026 18:26
jkatz01 added a commit that referenced this pull request Feb 25, 2026
…40503)

**Related issue:** Resolves #40412 

## Testing

- [x] Added/updated automated tests


- [x] QA'd all new/changed functionality manually

- Individually or together setting vpp, software installers, or fleet
maintained apps will send the correct error now when applied to no team
with manual_agent_install enabled.
jkatz01 added a commit that referenced this pull request Feb 25, 2026
… in gitops (#40533)

Related issue: Resolves #40412 
Merged to main in #40503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gitops: applying "No team" with manual_agent_install = true and a software marked as setup_experience: true is not prevented

2 participants