Fleet UI: Updates to manage host page for pending MDM#41810
Fleet UI: Updates to manage host page for pending MDM#41810RachelElysia merged 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #41810 +/- ##
==========================================
- Coverage 66.52% 66.52% -0.01%
==========================================
Files 2530 2530
Lines 203065 203073 +8
Branches 9105 9108 +3
==========================================
+ Hits 135083 135087 +4
- Misses 55775 55779 +4
Partials 12207 12207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
Seems like this subtask includes changes to the host page itself (I don't see that spec'd in the other two subtasks), so there's more to do here. @jahzielv can you get an ABM-enrolled Mac wiped and pointed at @RachelElysia's server to end-to-end test this? Should be testable even without API changes because pending hosts should show in the host list with filtering turned off.
What's here looks fine, but the third-from-left set of screens in Figma doesn't seem to have an explicitly corresponding FE ticket so here seems as good a place as any to get that functionality in.
|
@iansltx @jahzielv I can see enough from dogfood ABM pending hosts: to dev more of the host details page out. I can put it in on this PR since it's early and clean. |
iansltx
left a comment
iansltx
left a comment
There was a problem hiding this comment.
Given that you've checked this against Dogfood responses, should be good to go here with this inversion fix. Maybe worth adding a test or two to regression-test the one thing I caught?
| @@ -1167,7 +1161,7 @@ const HostDetailsPage = ({ | |||
| isHostTeamTechnician); | |||
|
|
|||
| const showSoftwareLibraryTab = isPremiumTier; | |||
|
|
|||
| const showQueriesCard = mdm?.enrollment_status === "Pending"; | |||
There was a problem hiding this comment.
| const showQueriesCard = mdm?.enrollment_status === "Pending"; | |
| const showQueriesCard = mdm?.enrollment_status !== "Pending"; |
We don't want to show when pending IIRC.
There was a problem hiding this comment.
100%
Apparently Nico just moved this section anyway, please check out my latest commit when re-reviewing!
There was a problem hiding this comment.
@marko-lisica / @melpike The queries section got moved back to its own tab. I guessed what the new intended behavior should be for pending hosts: show an empty state instead of potentially stale data.
Please confirm/revise the design as needed and I can do a followup PR
There was a problem hiding this comment.
@RachelElysia An empty state on the "Reports" tab for pending hosts sounds good to me. Updated the figma with dev note. Thanks!
There was a problem hiding this comment.
@melpike @RachelElysia does this mean that we'll have "Reports" tab only on pending hosts, and on enrolled hosts we have Reports card?
There was a problem hiding this comment.
@marko-lisica Reports card is being moved to the Reports tab for all. Here's the Figma for reference.
There was a problem hiding this comment.
Ah, I see. That makes sense.
RachelElysia
force-pushed
the
40798-pending-host
branch
from
cde71dc to
f5a5033
Compare
5 participants
Issue
Closes #40798
Description
status=pendingScreenshot of updates
Testing