Skip to content

Remove generate-gitops warning about categories#42514

Merged
sgress454 merged 1 commit intomainfrom
sgress454/remove-categories-warning
Mar 26, 2026
Merged

Remove generate-gitops warning about categories#42514
sgress454 merged 1 commit intomainfrom
sgress454/remove-categories-warning

Conversation

@sgress454
Copy link
Copy Markdown
Contributor

Related issue: Resolves #30453

All the work for this was already done in #32492. I verified that generate-gitops outputs the expected categories, and that gitops reads them back in correctly. This PR just removes the warning

Copilot AI review requested due to automatic review settings March 26, 2026 21:12
@sgress454 sgress454 requested a review from a team as a code owner March 26, 2026 21:12
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an outdated generate-gitops warning about software categories now that categories are supported end-to-end (implemented previously in #32492), aligning CLI output with current GitOps behavior.

Changes:

  • Delete the “Software categories are not supported by this tool yet…” note emitted by fleetctl generate-gitops for non-global runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgress454 sgress454 merged commit 83d1b02 into main Mar 26, 2026
45 checks passed
@sgress454 sgress454 deleted the sgress454/remove-categories-warning branch March 26, 2026 21:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.62%. Comparing base (f7f5664) to head (5cb505b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #42514      +/-   ##
==========================================
- Coverage   66.63%   66.62%   -0.01%     
==========================================
  Files        2532     2532              
  Lines      202555   202579      +24     
  Branches     9180     9180              
==========================================
+ Hits       134968   134973       +5     
- Misses      55384    55400      +16     
- Partials    12203    12206       +3     
Flag Coverage Δ
backend 68.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support software categories in generate-gitops

4 participants