Remove generate-gitops warning about categories#42514
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Removes an outdated generate-gitops warning about software categories now that categories are supported end-to-end (implemented previously in #32492), aligning CLI output with current GitOps behavior.
Changes:
- Delete the “Software categories are not supported by this tool yet…” note emitted by
fleetctl generate-gitopsfor non-global runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42514 +/- ##
==========================================
- Coverage 66.63% 66.62% -0.01%
==========================================
Files 2532 2532
Lines 202555 202579 +24
Branches 9180 9180
==========================================
+ Hits 134968 134973 +5
- Misses 55384 55400 +16
- Partials 12203 12206 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Related issue: Resolves #30453
All the work for this was already done in #32492. I verified that
generate-gitopsoutputs the expected categories, and thatgitopsreads them back in correctly. This PR just removes the warning