Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #32492 +/- ##
=======================================
Coverage 62.13% 62.13%
=======================================
Files 1986 1986
Lines 195471 195525 +54
Branches 6468 6468
=======================================
+ Hits 121448 121492 +44
- Misses 64346 64351 +5
- Partials 9677 9682 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
force-pushed
the
30095-gitops-changes
branch
from
69c4902 to
ecec668
Compare
7 tasks
…31811) Fixes #31164 - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually - [X] Verified that the setting is exported via `fleetctl generate-gitops` - [X] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [X] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
…to team level in GitOps (#32245) Fixes #31163. This also enables setup experience inclusion for FMAs. Includes checks and errors for invalid states. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually ## New Fleet configuration settings - [x] Verified that the setting is exported via `fleetctl generate-gitops` - [x] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [x] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Team-level control of software settings in GitOps: setup experience (install during setup), self-service, labels (include/exclude), and categories for packages and App Store apps. - Team-level settings are applied to individual packages automatically. - Validation - Clear errors when setup experience is defined in multiple places (software/app vs. macOS setup). - Documentation - Removed outdated note about GitOps-generated outputs. - Tests - Added test cases covering valid team-level configuration and conflicting placement scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Anthony Maxwell <133805840+Illbjorn@users.noreply.github.com>
iansltx
force-pushed
the
30095-gitops-changes
branch
from
552c868 to
35ec21e
Compare
lucasmrod
reviewed
Sep 3, 2025
This was referenced Mar 26, 2026
sgress454
added a commit
that referenced
this pull request
Mar 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #30453 All the work for this was already done in #32492. I verified that `generate-gitops` outputs the expected categories, and that `gitops` reads them back in correctly. This PR just removes the warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #30095.
#32482 is additional cleanup. Merging this to unblock orchestration Linux setup experience work. Code has already been reviewed prior to merging into the feature branch.