Skip to content

Comment out 1Password fleet policy and app#44178

Merged
allenhouchins merged 1 commit intomainfrom
allenhouchins-fix-1password
Apr 25, 2026
Merged

Comment out 1Password fleet policy and app#44178
allenhouchins merged 1 commit intomainfrom
allenhouchins-fix-1password

Conversation

@allenhouchins
Copy link
Copy Markdown
Member

@allenhouchins allenhouchins commented Apr 25, 2026

Temporarily disable 1Password-related Fleet checks and app entry. workstations.yml: commented out the macOS policies 1password-emergency-kit-check.yml and 1password-installed.yml and the fleet_maintained_apps entry for 1password/darwin. lib/macos/policies/patch-fleet-maintained-apps.yml: commented out the patch rule for 1password/darwin. This stops 1Password health checks and automatic patching until re-enabled.

Summary by CodeRabbit

  • Chores
    • Disabled 1Password management and automatic patching controls across macOS fleet configurations.

Temporarily disable 1Password-related Fleet checks and app entry. workstations.yml: commented out the macOS policies 1password-emergency-kit-check.yml and 1password-installed.yml and the fleet_maintained_apps entry for 1password/darwin. lib/macos/policies/patch-fleet-maintained-apps.yml: commented out the patch rule for 1password/darwin. This stops 1Password health checks and automatic patching until re-enabled.
@allenhouchins allenhouchins marked this pull request as ready for review April 25, 2026 02:41
Copilot AI review requested due to automatic review settings April 25, 2026 02:41
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins allenhouchins merged commit 8dcc43d into main Apr 25, 2026
4 of 5 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenhouchins allenhouchins deleted the allenhouchins-fix-1password branch April 25, 2026 02:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4bb94835-1eae-4aad-a407-323e0511a4f0

📥 Commits

Reviewing files that changed from the base of the PR and between a4229fb and ea63a32.

📒 Files selected for processing (2)
  • it-and-security/fleets/workstations.yml
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml

Walkthrough

The pull request disables 1Password-related controls in macOS configuration files. Specifically, it comments out active policy includes for 1password-emergency-kit-check.yml and 1password-installed.yml in the workstations fleet configuration, removes the 1password/darwin fleet maintained app entry, and disables the macOS - 1Password up to date patch policy definition by replacing it with commented-out text.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-fix-1password

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants