Skip to content

Revert "Comment out 1Password fleet policy and app"#44180

Merged
allenhouchins merged 2 commits intomainfrom
revert-44178-allenhouchins-fix-1password
Apr 25, 2026
Merged

Revert "Comment out 1Password fleet policy and app"#44180
allenhouchins merged 2 commits intomainfrom
revert-44178-allenhouchins-fix-1password

Conversation

@allenhouchins
Copy link
Copy Markdown
Member

@allenhouchins allenhouchins commented Apr 25, 2026

Reverts #44178

Summary by CodeRabbit

Release Notes

  • New Features
    • Enabled 1Password emergency kit verification for macOS devices
    • Made 1Password available as a self-service application with automated setup on macOS
    • Activated maintenance and patch management for 1Password

fleet-release
fleet-release previously approved these changes Apr 25, 2026
Comment out the 1Password policy path in workstations.yml.
@allenhouchins allenhouchins marked this pull request as ready for review April 25, 2026 02:55
Copilot AI review requested due to automatic review settings April 25, 2026 02:55
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenhouchins allenhouchins merged commit 93a2543 into main Apr 25, 2026
4 of 5 checks passed
@allenhouchins allenhouchins deleted the revert-44178-allenhouchins-fix-1password branch April 25, 2026 02:55
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 001c00b1-a74a-4c3d-9306-97d26172fc1f

📥 Commits

Reviewing files that changed from the base of the PR and between 8dcc43d and 7e918ef.

📒 Files selected for processing (2)
  • it-and-security/fleets/workstations.yml
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml

Walkthrough

This pull request activates 1Password-related configurations in the Fleet workstations setup. It enables the 1Password emergency kit check policy in the active policies list and configures the 1Password/darwin fleet-maintained app with self-service and setup experience enabled under the Security category. Additionally, it converts the 1Password macOS patch policy from a commented state to an active configuration with specific matching criteria and patch settings for fleet-maintained app patching.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-44178-allenhouchins-fix-1password

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants