Add Amazon Corretto 25 as a Windows FMA#46220
Conversation
Add support for Amazon Corretto 25 across the repo: new winget input definition, Windows output metadata (version 25.0.3.9) including installer/uninstaller PowerShell scripts, SHA256 and upgrade_code, and register the app in ee/maintained-apps/outputs/apps.json. Also add a frontend SVG icon component, map it in the icons index, and include the 2x PNG asset so the app is displayed in the UI. This enables Fleet to install and uninstall Amazon Corretto 25 on Windows.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46220 +/- ##
==========================================
+ Coverage 66.83% 66.85% +0.01%
==========================================
Files 2757 2759 +2
Lines 220189 220757 +568
Branches 11006 10879 -127
==========================================
+ Hits 147161 147583 +422
- Misses 59735 59830 +95
- Partials 13293 13344 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Allow searching programs by the app's unique_identifier when it differs from the catalog name and validate the input to avoid unsafe SQL. Updates cmd/maintained-apps/validate/windows.go to append an OR condition for uniqueIdentifier (with validateSqlInput guard) and keep existing install_location checks. Adjusts Amazon Corretto 25 metadata and queries: change unique_identifier to "Amazon Corretto (x64)", update the exists and patched queries to search the DisplayName and use version LIKE '25.%', and update apps.json accordingly. This addresses mismatches between catalog names and registry DisplayName entries so the presence/patch checks work reliably.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Adds Amazon Corretto 25 as a Fleet-maintained app (Windows) and wires it through both the maintained-apps pipeline and the frontend UI icon set so it can be displayed and managed in Fleet.
Changes:
- Added a Winget input definition and generated Windows maintained-app output metadata for Amazon Corretto 25 (including installer/uninstaller scripts, SHA256, and upgrade code).
- Registered the app in the maintained-apps catalog (
apps.json). - Added a new frontend icon component and mapped the software name to the icon.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Adds import + name→icon mapping for “Amazon Corretto 25”. |
| frontend/pages/SoftwarePage/components/icons/AmazonCorretto25.tsx | Adds the Amazon Corretto 25 icon component (embedded PNG in SVG). |
| ee/maintained-apps/outputs/apps.json | Registers Amazon Corretto 25 in the maintained apps list. |
| ee/maintained-apps/outputs/amazon-corretto-25/windows.json | Adds Windows maintained-app output: version metadata, queries, scripts, SHA256, and upgrade_code. |
| ee/maintained-apps/inputs/winget/amazon-corretto-25.json | Adds the Winget input definition used to generate/track this maintained app. |
| cmd/maintained-apps/validate/windows.go | Updates Windows validator existence-check logic to also search by unique_identifier when it differs from the catalog name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
WalkthroughThis PR adds Amazon Corretto 25 (Java distribution) as a maintained Windows application in Fleet. The changes enhance Windows app detection by extending the Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add support for Amazon Corretto 25 across the repo: new winget input definition, Windows output metadata (version 25.0.3.9) including installer/uninstaller PowerShell scripts, SHA256 and upgrade_code, and register the app in ee/maintained-apps/outputs/apps.json. Also add a frontend SVG icon component, map it in the icons index, and include the 2x PNG asset so the app is displayed in the UI. This enables Fleet to install and uninstall Amazon Corretto 25 on Windows.
Summary by CodeRabbit
Release Notes