Skip to content

Website: Workspace ONE no longer supports on-prem (EOL 2027)#46490

Open
mikermcneil wants to merge 2 commits into
mainfrom
mikermcneil-patch-30
Open

Website: Workspace ONE no longer supports on-prem (EOL 2027)#46490
mikermcneil wants to merge 2 commits into
mainfrom
mikermcneil-patch-30

Conversation

@mikermcneil
Copy link
Copy Markdown
Member

@mikermcneil mikermcneil commented May 29, 2026

  • Update homepage.ejs

Summary by CodeRabbit

  • Style
    • Updated the "Cloud or self-host" comparison on the homepage: the Omnissa (WS1) option now shows a red "x" icon instead of the phrase "On‑prem discouraged" in both desktop and mobile tables for clearer, more consistent visuals.

Review Change Stack

@fleet-release fleet-release requested a review from eashaw May 29, 2026 20:23
@fleet-release fleet-release added the ~ga4-annotation This label is automatically applied to certain website changes label May 29, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

fleet-release
fleet-release previously approved these changes May 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ed5fd8b1-9352-4904-b86c-3d89a2ef5b92

📥 Commits

Reviewing files that changed from the base of the PR and between 435bc95 and b58d3f8.

📒 Files selected for processing (1)
  • website/views/pages/homepage.ejs
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/views/pages/homepage.ejs

Walkthrough

This PR replaces the Omnissa (WS1) "On-prem discouraged" text with a red-x icon in the "Cloud or self-host" comparison row on the homepage. The update applies to both the desktop and mobile comparison tables and is implemented in website/views/pages/homepage.ejs (two single-line edits).

Possibly related PRs

  • fleetdm/fleet#46319: Overlapping edits to the homepage comparison table logic and competitor status labels in homepage.ejs.
  • fleetdm/fleet#45001: Related modifications to homepage.ejs around the Workspace ONE / Omnissa comparison table UI.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and incomplete, lacking detail about the changes made and omitting required checklist items from the template. Expand the description to explain why the change was made (EOL 2027) and complete the relevant checklist items, particularly testing and changes file documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the Omnissa (WS1) row in the comparison tables to display a red-x icon instead of 'On-prem discouraged' text, reflecting the EOL 2027 end-of-support status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mikermcneil-patch-30

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~ga4-annotation This label is automatically applied to certain website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants