Update homepage comparison table#46319
Conversation
Resolves fleetdm/confidential#16119 - Re-orders and removes rows - Replaces platform icons for easier to scan checkmarks - Adds additional context in tooltips
fleet-release
added
the
~ga4-annotation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR updates the homepage comparison tables (desktop and mobile versions) with revised feature labels, tooltips, and competitor capability mappings. Feature names are updated—"Operating system updates" becomes "Software updates," and "Configuration management & scripting" becomes "Configuration, scripting, and diagnostics." Tooltips are rewritten for "Complete device inventory" and "Device reporting." Competitor outcomes are adjusted to show specific capabilities: "Device reporting" maps intune to "6 hours" and puppet/chef/ansible to "One-off scripts," while "Cloud or self-host" introduces status text with tooltip links for jamf/tanium and plain text for other competitors. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
website/views/pages/homepage.ejs (1)
419-419:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix typo and standardize status casing across desktop/mobile.
Line 419 has a typo: “scription” should be “scripting.”
Also, the same outcome is inconsistent between Line 271 (“6 hours”) and Line 447 (“6 Hours”). Please use one style in both tables.Also applies to: 447-447
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@website/views/pages/homepage.ejs` at line 419, Fix the typo by changing the paragraph text "Windows only scription for app installs" to "Windows only scripting for app installs" (edit the <p> element containing that exact string), and standardize the status/casing across both desktop and mobile tables by making "6 Hours" consistent with "6 hours" (search for the exact "6 Hours" string in the same file and replace it with "6 hours" so both table entries use the same lowercase style).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/views/pages/homepage.ejs`:
- Line 260: The tooltip copy in the img elements uses "Unlike traditional
system…" which is grammatically incorrect; locate the <img> elements with
purpose="tooltip-icon" (the ones whose title attributes start with "Unlike
traditional system") and update the title text to "Unlike traditional systems
that can take from 1 - 6 hours to respond. Fleet can talk to thousands of
devices in seconds." at both occurrences (the current instances around the shown
lines and the similar one near the second occurrence) so the word "system"
becomes plural "systems".
---
Outside diff comments:
In `@website/views/pages/homepage.ejs`:
- Line 419: Fix the typo by changing the paragraph text "Windows only scription
for app installs" to "Windows only scripting for app installs" (edit the <p>
element containing that exact string), and standardize the status/casing across
both desktop and mobile tables by making "6 Hours" consistent with "6 hours"
(search for the exact "6 Hours" string in the same file and replace it with "6
hours" so both table entries use the same lowercase style).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7a06c52b-ef09-4341-90da-b435ed0d5c43
📒 Files selected for processing (1)
website/views/pages/homepage.ejs
| <div purpose="feature-name"> | ||
| <p> | ||
| Device reporting (<30 seconds) | ||
| <img class="d-inline" purpose="tooltip-icon" src="/images/icon-more-info-14x14@2x.png" alt="More info" data-toggle="tooltip" tabindex="0" data-placement="top" title="Unlike traditional system that can take from 1 - 6 hours to respond. Fleet can talk to thousands of devices in seconds."> |
There was a problem hiding this comment.
Polish tooltip grammar for user-facing copy.
At Line 260 and Line 433, “Unlike traditional system…” should be plural (“systems”) for correct grammar.
Also applies to: 433-433
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/views/pages/homepage.ejs` at line 260, The tooltip copy in the img
elements uses "Unlike traditional system…" which is grammatically incorrect;
locate the <img> elements with purpose="tooltip-icon" (the ones whose title
attributes start with "Unlike traditional system") and update the title text to
"Unlike traditional systems that can take from 1 - 6 hours to respond. Fleet can
talk to thousands of devices in seconds." at both occurrences (the current
instances around the shown lines and the similar one near the second occurrence)
so the word "system" becomes plural "systems".
Fixed typo
|
Urgh, maybe we should add the tabs after all. The dropdown is cleaner and gets a lot of clicks, but many folks still aren't seeing who Fleet compares to directly. @eashaw, can you help me add them in — I couldn't figure it out. |
3 participants
Resolves https://github.com/fleetdm/confidential/issues/16119
I decided against adding tabs. They added visual weight without enough benefit. The dropdown is clear enough on its own, and it's already the second-most-clicked button on the page.
Summary by CodeRabbit