Skip to content

Update docs for deploying Fleet on Kubernetes#4755

Merged
DominusKelvin merged 13 commits intomainfrom
update-docs-on-deploying-fleet-on-kubernetes
May 9, 2022
Merged

Update docs for deploying Fleet on Kubernetes#4755
DominusKelvin merged 13 commits intomainfrom
update-docs-on-deploying-fleet-on-kubernetes

Conversation

@DominusKelvin
Copy link
Copy Markdown
Contributor

@DominusKelvin DominusKelvin commented Mar 23, 2022

This PR when complete should close the issue #4663

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fleet-dm/fleet/2aMuoJfaCLREbRGxHU84eJPwh17B
✅ Preview: https://fleet-git-update-docs-on-deploying-fleet-on-kubernetes-fleet-dm.vercel.app

@gitpod-io
Copy link
Copy Markdown

gitpod-io Bot commented Mar 23, 2022

@DominusKelvin
Copy link
Copy Markdown
Contributor Author

DominusKelvin commented Mar 23, 2022

@zwass I created this PR prematurely to get active feedback on the directions for the update. For one, seeing the logs of kubectl log <cluster-name> it's obvious we need MySQL all set up.

Should I go ahead and set up the container as well?

@zwass
Copy link
Copy Markdown
Member

zwass commented Mar 23, 2022

Let's assume MySQL and Redis are already running and just cover how to get Fleet running and connected to the dependencies.

@DominusKelvin
Copy link
Copy Markdown
Contributor Author

DominusKelvin commented Mar 28, 2022

@zwass alright

@DominusKelvin DominusKelvin temporarily deployed to Docker Hub March 29, 2022 11:06 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub March 29, 2022 12:31 Inactive
zwinnerman-fleetdm
zwinnerman-fleetdm reviewed Mar 29, 2022
View reviewed changes
Comment thread docs/Deploying/Server-Installation.md
zwinnerman-fleetdm
zwinnerman-fleetdm reviewed Mar 29, 2022
View reviewed changes
Comment thread docs/Deploying/Server-Installation.md Outdated
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub March 31, 2022 12:57 Inactive
@DominusKelvin DominusKelvin changed the title feat[WIP]: updating docs for deploying Fleet on Kubernetes feat: updating docs for deploying Fleet on Kubernetes Mar 31, 2022
@DominusKelvin DominusKelvin changed the title feat: updating docs for deploying Fleet on Kubernetes Update docs for deploying Fleet on Kubernetes Mar 31, 2022
@mike-j-thomas
Copy link
Copy Markdown
Member

mike-j-thomas commented Apr 13, 2022

@DominusKelvin, it looks like this has been pending review for a while. Are there any remaining TODOs to resolve @zwinnerman-fleetdm 's review comments, and get this merged? Thanks.

@DominusKelvin DominusKelvin temporarily deployed to Docker Hub April 13, 2022 17:14 Inactive
doc: add Kubernetes manifest file
1676385 
Add Kubernetes manifest file to files to be edited for Fleet version change when releasing.
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub April 13, 2022 17:26 Inactive
@DominusKelvin
Copy link
Copy Markdown
Contributor Author

DominusKelvin commented Apr 13, 2022

@DominusKelvin, it looks like this has been pending review for a while. Are there any remaining TODOs to resolve @zwinnerman-fleetdm 's review comments, and get this merged? Thanks.

Done.

@DominusKelvin
Copy link
Copy Markdown
Contributor Author

DominusKelvin commented Apr 13, 2022

@zwass and @zwinnerman-fleetdm I added the reference to update the Kubernetes manifest file in the releasing docs.

@mikermcneil mikermcneil added the :improve documentation Involves writing improvements or additions to documentation label May 5, 2022
@mikermcneil
Copy link
Copy Markdown
Member

mikermcneil commented May 5, 2022

This PR is starting to collect merge conflicts.

@noahtalerman Can you help Kelvin get this merged this week?

noahtalerman
noahtalerman requested changes May 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking sweet! I left a couple requested changes below :)

Comment thread docs/Contributing/Releasing-Fleet.md Outdated
Comment thread docs/Deploying/Server-Installation.md Outdated
Comment thread docs/Deploying/Server-Installation.md
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 5, 2022 17:08 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 5, 2022 17:08 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 5, 2022 17:09 Inactive
@DominusKelvin DominusKelvin force-pushed the update-docs-on-deploying-fleet-on-kubernetes branch from 079f48f to 9579326 Compare May 6, 2022 12:51
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 6, 2022 12:51 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 6, 2022 12:53 Inactive
@noahtalerman
Copy link
Copy Markdown
Member

noahtalerman commented May 6, 2022

@DominusKelvin looks good to go!

@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 9, 2022 12:55 Inactive
@noahtalerman
Copy link
Copy Markdown
Member

noahtalerman commented May 9, 2022

@DominusKelvin when you get the chance, can you please merge this PR in during the code freeze?

This way, I can update the new deployment.yml file with the latest Fleet version (4.14.0) in my "Prepare for 4.14.0" PR here: #5589

@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 9, 2022 16:04 Inactive
@DominusKelvin DominusKelvin merged commit a5da7c9 into main May 9, 2022
@DominusKelvin DominusKelvin deleted the update-docs-on-deploying-fleet-on-kubernetes branch May 9, 2022 16:05
@DominusKelvin
Copy link
Copy Markdown
Contributor Author

DominusKelvin commented May 9, 2022

Done @noahtalerman

DominusKelvin pushed a commit that referenced this pull request May 12, 2022
@DominusKelvin
Update docs for deploying Fleet on Kubernetes (#4755)
f3d61e8 
* feat[WIP]: updating docs for deploying Fleet on Kubernetes

* feat: update spec to include environment variables

* chore: add fleet image version to yml file

* doc: add Kubernetes manifest file

Add Kubernetes manifest file to files to be edited for Fleet version change when releasing.

* docs: link to the docs on deploying Fleet via K8s

* feat: add kubernetes deployment.yml

* feat: update Fleet version
Desmi-Dizney added a commit that referenced this pull request May 12, 2022
@Desmi-Dizney
Editor pass - Update docs for deploying Fleet on Kubernetes
8948d18 
Editor pass for:
-  #4755
@Desmi-Dizney Desmi-Dizney mentioned this pull request May 12, 2022
Merged
@Desmi-Dizney
Copy link
Copy Markdown
Contributor

Desmi-Dizney commented May 12, 2022 •
edited
Loading

Editor pass completed on:

noahtalerman pushed a commit that referenced this pull request May 19, 2022
@Desmi-Dizney
Editor pass - Update docs for deploying Fleet on Kubernetes (#5719)
72d859b 
Editor pass for:
-  #4755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwass zwass zwass left review comments

@noahtalerman noahtalerman noahtalerman approved these changes

+1 more reviewer

@zwinnerman-fleetdm zwinnerman-fleetdm zwinnerman-fleetdm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:improve documentation Involves writing improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DominusKelvin @zwass @mike-j-thomas @mikermcneil @noahtalerman @Desmi-Dizney @zwinnerman-fleetdm