Editor pass - Update docs for deploying Fleet on Kubernetes#5719
Editor pass - Update docs for deploying Fleet on Kubernetes#5719noahtalerman merged 1 commit intomainfrom
Conversation
Editor pass for: - #4755
| To deploy the Fleet server and connect to its dependencies(MySQL and Redis) we will set up a `deployment.yml` file with the following specifications: | ||
| To deploy the Fleet server and connect to its dependencies(MySQL and Redis), we will set up a `deployment.yml` file with the following specifications: | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
@noahtalerman, do we want to capitalize "yaml" and "fleet" in this section?
There was a problem hiding this comment.
@Desmi-Dizney are you referring to yaml on line 429? If so, I think we do want to keep this lowercase.
We want to keep yaml lowercase because this is a keyword that GitHub uses to render the correct syntax highlighting.
@DominusKelvin do you know if there's a reason to keep fleet lowercase in the example deployment.yml file? Specifically on line 440, 444, and 447.
There was a problem hiding this comment.
@DominusKelvin, whenever you get a moment, let me know on this one.
There was a problem hiding this comment.
@Desmi-Dizney @noahtalerman Just my two cents, but I think that since most of us are used to code being camelcase, it makes sense to stick with that in the code examples. If for no other reason than that fleet feels a lot more natural than Fleet in this context to type out and since it's happening multiple times there's a good chance an f would slip in there somewhere.
There was a problem hiding this comment.
And I'm sure I'm not the only one that avoids copy/paste from pretty much anywhere for blocks of code because VSC and invisible characters have burned me three too many times.
There was a problem hiding this comment.
Makes sense! Thanks Kathy.
3 participants
Editor pass for: