GitHub webhook: Add support for '*' DRI rule#4825
Merged
mikermcneil merged 8 commits intomainfrom Mar 26, 2022
Merged
Conversation
This allows any fleetie to edit the handbook landing page (e.g. in the event pages need to get moved around)
fleet-release
previously approved these changes
Mar 26, 2022
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fleet-dm/fleet/EG98sLPUd6DfJpysiu3SWEiSg1VS |
mikermcneil
commented
Mar 26, 2022
|
|
||
| 'docs': ['mike-j-thomas', 'zwass'],// (default for docs) | ||
|
|
||
| 'docs/01-Using-Fleet/standard-query-library/standard-query-library.yml': ['guillaumeross', 'zwass'],// (standard query library) |
mikermcneil
commented
Mar 26, 2022
| 'handbook/customers.md': 'tgauda', | ||
| 'handbook/community.md': 'mike-j-thomas', | ||
| 'handbook/handbook.md': 'mike-j-thomas', | ||
| 'handbook/community.md': ['dominuskelvin', 'ksatter', 'mike-j-thomas'], |
Member
Author
There was a problem hiding this comment.
fleet-release
previously approved these changes
Mar 26, 2022
fleet-release
previously approved these changes
Mar 26, 2022
mikermcneil
commented
Mar 26, 2022
fleet-release
previously approved these changes
Mar 26, 2022
fleet-release
approved these changes
Mar 26, 2022
mikermcneil
added a commit
that referenced
this pull request
Mar 26, 2022
mikermcneil
added a commit
that referenced
this pull request
Mar 26, 2022
fixes unfinished logic from #4825
mikermcneil
added a commit
that referenced
this pull request
Mar 26, 2022
martavis
pushed a commit
to martavis/fleet
that referenced
this pull request
Mar 27, 2022
* GitHub webhook: Add support for '*' DRI rule This allows any fleetie to edit the handbook landing page (e.g. in the event pages need to get moved around) * invert how DRI rules for website are expressed * lint fix + add support for array syntax * Update receive-from-github.js * Update receive-from-github.js * Update receive-from-github.js * Update receive-from-github.js * Update receive-from-github.js
martavis
pushed a commit
to martavis/fleet
that referenced
this pull request
Mar 27, 2022
fixes unfinished logic from fleetdm#4825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows any fleetie to edit the handbook landing page (e.g. in the event pages need to get moved around)