GitHub webhook: Fixes #4825 to support multiple "self mergers"#4827
Merged
mikermcneil merged 1 commit intomainfrom Mar 26, 2022
Merged
GitHub webhook: Fixes #4825 to support multiple "self mergers"#4827mikermcneil merged 1 commit intomainfrom
mikermcneil merged 1 commit intomainfrom
Conversation
fixes unfinished logic from #4825
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fleet-dm/fleet/CqjmcVyLjQgfGZYrSb9srcwrMcpp |
|
|
Member
Author
|
fixes #4826 |
mikermcneil
added a commit
that referenced
this pull request
Mar 26, 2022
followup fix for #4827 (this is what I get for rushing)
mikermcneil
added a commit
that referenced
this pull request
Mar 26, 2022
martavis
pushed a commit
to martavis/fleet
that referenced
this pull request
Mar 27, 2022
fixes unfinished logic from fleetdm#4825
martavis
pushed a commit
to martavis/fleet
that referenced
this pull request
Mar 27, 2022
followup fix for fleetdm#4827 (this is what I get for rushing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes unfinished logic from #4825
as proven by https://github.com/fleetdm/fleet/pull/4826/files, #4825 doesn't work because it's not properly handling arrays. Now it does.