Skip to content

Manage Hosts: Custom host vitals entry point - #48904

Merged
nulmete merged 1 commit into
44954-custom-host-vitalsfrom
48557-manage-hosts-custom-host-vitals
Jul 8, 2026
Merged

Manage Hosts: Custom host vitals entry point#48904
nulmete merged 1 commit into
44954-custom-host-vitalsfrom
48557-manage-hosts-custom-host-vitals

Conversation

@nulmete

@nulmete nulmete commented Jul 7, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #48557

Adds a "Custom host vitals" header button that navigates there to the new Custom host vitals tab, and restyles the adjacent enroll-secret button per design (gear icon + "Enroll secrets" label).

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Will be added in feature branch.

Testing

  • Added/updated automated tests

  • QA'd all new/changed functionality manually

Screen.Recording.2026-07-07.at.5.05.16.PM.mov

…rets button

Add a "Custom host vitals" header button on the Manage Hosts page that
navigates to the Controls > Variables > Custom host vitals tab, preserving
the current fleet via fleet_id. Restyle the adjacent enroll-secret button
per design: leading gear icon and "Enroll secrets" label. Both buttons are
gated to global admins/maintainers, matching the tab's own edit gating.
@nulmete
nulmete marked this pull request as ready for review July 7, 2026 20:06
@nulmete
nulmete requested a review from a team as a code owner July 7, 2026 20:06
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (44954-custom-host-vitals@22e86dd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nd/pages/hosts/ManageHostsPage/ManageHostsPage.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             44954-custom-host-vitals   #48904   +/-   ##
===========================================================
  Coverage                            ?   67.88%           
===========================================================
  Files                               ?     3685           
  Lines                               ?   233900           
  Branches                            ?    12459           
===========================================================
  Hits                                ?   158782           
  Misses                              ?    60856           
  Partials                            ?    14262           
Flag Coverage Δ
frontend 58.85% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nulmete
nulmete merged commit b93bfde into 44954-custom-host-vitals Jul 8, 2026
21 checks passed
@nulmete
nulmete deleted the 48557-manage-hosts-custom-host-vitals branch July 8, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants