Skip to content

Update Fleet-maintained apps - #48936

Merged
allenhouchins merged 2 commits into
mainfrom
fma-2607081228
Jul 8, 2026
Merged

Update Fleet-maintained apps#48936
allenhouchins merged 2 commits into
mainfrom
fma-2607081228

Conversation

@fleet-release

@fleet-release fleet-release commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Bug Fixes
    • Updated several app packages to newer releases, including Adobe DNG Converter, BitBox, Capto, Cursor, Dropshare, Fastmail, GitKraken, GoLand, Google Chrome, Gemini, Krisp, Melodics, Notion, PhpStorm, Postman, Readest, RightFont, Rive, RubyMine, Sequel Ace, TablePlus, Unity Hub, Viscosity, Visual Studio Code, WebStorm, Windows App, and Worksheet Crafter.
    • Improved some macOS install/uninstall flows to better handle apps that are already running and to clean up leftover preference files.

Generated automatically with cmd/maintained-apps.
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/adobe-dng-converter/darwin.json

=== Install // 5b77b60e -> f1e56d5b ===

--- /tmp/old.Kcwdm0	2026-07-08 12:37:21.699414240 +0000
+++ /tmp/new.tGG8wp	2026-07-08 12:37:21.699414240 +0000
@@ -101,5 +101,5 @@
 hdiutil detach "$MOUNT_POINT" || true
 # install pkg files
 quit_and_track_application 'com.adobe.DNGConverter'
-sudo installer -pkg "$TMPDIR/DNGConverter_18_4.pkg" -target /
+sudo installer -pkg "$TMPDIR/DNGConverter_18_4_1.pkg" -target /
 relaunch_application 'com.adobe.DNGConverter'

=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/antigravity/darwin.json

=== Install Script (no changes) ===
=== Uninstall // d695eb0f -> 8838465b ===

--- /tmp/old.SFCmOM	2026-07-08 12:37:21.741415723 +0000
+++ /tmp/new.hab1kX	2026-07-08 12:37:21.741415723 +0000
@@ -101,5 +101,7 @@
 trash $LOGGED_IN_USER '~/Library/Caches/com.google.antigravity'
 trash $LOGGED_IN_USER '~/Library/Caches/com.google.antigravity.ShipIt'
 trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.google.antigravity'
+trash $LOGGED_IN_USER '~/Library/Logs/Antigravity'
+trash $LOGGED_IN_USER '~/Library/Preferences/ByHost/com.google.antigravity.ShipIt.*.plist'
 trash $LOGGED_IN_USER '~/Library/Preferences/com.google.antigravity.plist'
 trash $LOGGED_IN_USER '~/Library/Saved Application State/com.google.Antigravity.savedState'

ee/maintained-apps/outputs/bitbox/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/capto/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/cursor/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/dropshare/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/fastmail/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/gitkraken/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/goland/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-chrome/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-chrome/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-gemini/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/krisp/darwin.json

=== Install // ac635988 -> 96f45265 ===

--- /tmp/old.MLsM1B	2026-07-08 12:37:22.089428014 +0000
+++ /tmp/new.D0MhoS	2026-07-08 12:37:22.089428014 +0000
@@ -96,5 +96,5 @@
 
 # install pkg files
 quit_and_track_application 'ai.krisp.krispMac'
-sudo installer -pkg "$TMPDIR/krisp_3.13.8_arm64.pkg" -target /
+sudo installer -pkg "$TMPDIR/krisp_3.13.12_arm64.pkg" -target /
 relaunch_application 'ai.krisp.krispMac'

=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/melodics/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/notion/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/phpstorm/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/postman/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/postman/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/readest/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rightfont/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rive/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rubymine/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/sequel-ace/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/tableplus/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/unity-hub/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/viscosity/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/viscosity/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/visual-studio-code/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/webstorm/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/windows-app/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/worksheet-crafter/darwin.json

=== Install // 545289c7 -> 9be99456 ===

--- /tmp/old.NIfffE	2026-07-08 12:37:22.707450068 +0000
+++ /tmp/new.3OZ0ZG	2026-07-08 12:37:22.707450068 +0000
@@ -96,5 +96,5 @@
 
 # install pkg files
 quit_and_track_application 'com.SchoolCraft.WillBeReplacedByQMake'
-sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.4.pkg" -target /
+sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.11.pkg" -target /
 relaunch_application 'com.SchoolCraft.WillBeReplacedByQMake'

=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • :ai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 95c1a75a-5d0d-4ba3-90b1-a8e6f8489544

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates numerous Fleet maintained-apps output JSON manifests, bumping application versions across both macOS (darwin.json) and Windows (windows.json) entries. For each app, the version field, queries.patched version-comparison thresholds, installer_url, and sha256 checksums were updated to reflect new releases. Several entries additionally update install or uninstall script references: Adobe DNG Converter's install script now tracks and conditionally relaunches the app via launchctl asuser after installation; Antigravity's uninstall script adds cleanup of a ShipIt preferences plist; Krisp and Worksheet Crafter update their install scripts to target new package filenames. Apps affected include Adobe DNG Converter, Antigravity, BitBox, Capto, Cursor, Dropshare, Fastmail, GitKraken, GoLand, Google Chrome, Google Gemini, Krisp, Melodics, Notion, PhpStorm, Postman, Readest, RightFont, Rive, RubyMine, Sequel Ace, TablePlus, Unity Hub, Viscosity, Visual Studio Code, WebStorm, Windows App, and Worksheet Crafter.

Possibly related PRs

  • fleetdm/fleet#47819: Updates macOS maintained-app installer scripts with the same running-state tracking and conditional launchctl asuser relaunch logic.
  • fleetdm/fleet#47828: Modifies the same ee/maintained-apps/outputs/adobe-dng-converter/darwin.json entry, updating install_script_ref and embedded installer bash logic alongside version metadata.
  • fleetdm/fleet#47010: Introduces the Antigravity output and scripts that this PR extends by updating the uninstall_script_ref and its bash uninstall script.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too vague and omits the required issue link, checklist items, and testing details from the template. Add the template sections, including related issue, checklist items, testing, and any applicable migration or configuration notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating Fleet-maintained apps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2607081228

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
ee/maintained-apps/outputs/worksheet-crafter/darwin.json (1)

19-19: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

pgrep -f "$bundle_id" likely never matches the app process.

In quit_and_track_application, the quit-verification loop uses pgrep -f "$bundle_id" to check if the app is still running. On macOS, GUI app processes show their executable path (e.g. /Applications/Worksheet Crafter.app/Contents/MacOS/WorksheetCrafter), not the bundle identifier. So pgrep -f "com.SchoolCraft.WillBeReplacedByQMake" will almost always return no matches, causing the loop to immediately report success on the first iteration — the 10-second polling loop is effectively dead code.

Consider matching against the app name or executable path instead, or use osascript -e "application id \"$bundle_id\" is running" for the running check (which you already use earlier in the same function).

♻️ Suggested fix: use osascript for quit verification
   SECONDS=0
   while (( SECONDS < timeout_duration )); do
     if osascript -e "tell application id \"$bundle_id\" to quit" >/dev/null 2>&1; then
-      if ! pgrep -f "$bundle_id" >/dev/null 2>&1; then
+      local still_running
+      still_running=$(osascript -e "application id \"$bundle_id\" is running" 2>/dev/null)
+      if [[ "$still_running" != "true" ]]; then
         echo "Application '$bundle_id' quit successfully."
         quit_success=true
         break
       fi
     fi
     sleep 1
   done
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/worksheet-crafter/darwin.json` at line 19, The
quit verification in quit_and_track_application is using pgrep -f with the
bundle identifier, which does not match macOS GUI app processes reliably. Update
the polling logic to verify the app is still running using the same
AppleScript-based check already used in quit_and_track_application (or match the
actual app executable/name instead of the bundle id), and keep the timeout loop
so it only reports success after the app is truly gone.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/krisp/darwin.json`:
- Around line 18-19: The install flow has a filename casing mismatch between the
downloaded package and the hardcoded package path used in the script. Update the
install command in the Krisp shell script to use the existing
INSTALLER_PATH-derived value instead of reconstructing krisp_3.13.12_arm64.pkg,
so it stays aligned with the installer_url casing and avoids case-sensitive APFS
failures. Keep the fix localized to the script that defines TMPDIR and runs sudo
installer, and ensure the path comes from the same variable used by the download
step.

---

Nitpick comments:
In `@ee/maintained-apps/outputs/worksheet-crafter/darwin.json`:
- Line 19: The quit verification in quit_and_track_application is using pgrep -f
with the bundle identifier, which does not match macOS GUI app processes
reliably. Update the polling logic to verify the app is still running using the
same AppleScript-based check already used in quit_and_track_application (or
match the actual app executable/name instead of the bundle id), and keep the
timeout loop so it only reports success after the app is truly gone.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 76b9e250-6089-4682-a263-abe31918c146

📥 Commits

Reviewing files that changed from the base of the PR and between b6e0cac and 7979c89.

📒 Files selected for processing (31)
  • ee/maintained-apps/outputs/adobe-dng-converter/darwin.json
  • ee/maintained-apps/outputs/antigravity/darwin.json
  • ee/maintained-apps/outputs/bitbox/darwin.json
  • ee/maintained-apps/outputs/capto/darwin.json
  • ee/maintained-apps/outputs/cursor/darwin.json
  • ee/maintained-apps/outputs/dropshare/darwin.json
  • ee/maintained-apps/outputs/fastmail/darwin.json
  • ee/maintained-apps/outputs/gitkraken/windows.json
  • ee/maintained-apps/outputs/goland/windows.json
  • ee/maintained-apps/outputs/google-chrome/darwin.json
  • ee/maintained-apps/outputs/google-chrome/windows.json
  • ee/maintained-apps/outputs/google-gemini/darwin.json
  • ee/maintained-apps/outputs/krisp/darwin.json
  • ee/maintained-apps/outputs/melodics/darwin.json
  • ee/maintained-apps/outputs/notion/windows.json
  • ee/maintained-apps/outputs/phpstorm/windows.json
  • ee/maintained-apps/outputs/postman/darwin.json
  • ee/maintained-apps/outputs/postman/windows.json
  • ee/maintained-apps/outputs/readest/windows.json
  • ee/maintained-apps/outputs/rightfont/darwin.json
  • ee/maintained-apps/outputs/rive/darwin.json
  • ee/maintained-apps/outputs/rubymine/windows.json
  • ee/maintained-apps/outputs/sequel-ace/darwin.json
  • ee/maintained-apps/outputs/tableplus/windows.json
  • ee/maintained-apps/outputs/unity-hub/darwin.json
  • ee/maintained-apps/outputs/viscosity/darwin.json
  • ee/maintained-apps/outputs/viscosity/windows.json
  • ee/maintained-apps/outputs/visual-studio-code/darwin.json
  • ee/maintained-apps/outputs/webstorm/windows.json
  • ee/maintained-apps/outputs/windows-app/windows.json
  • ee/maintained-apps/outputs/worksheet-crafter/darwin.json

Comment on lines 18 to +19
"refs": {
"ac635988": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# install pkg files\nquit_and_track_application 'ai.krisp.krispMac'\nsudo installer -pkg \"$TMPDIR/krisp_3.13.8_arm64.pkg\" -target /\nrelaunch_application 'ai.krisp.krispMac'\n",
"96f45265": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# install pkg files\nquit_and_track_application 'ai.krisp.krispMac'\nsudo installer -pkg \"$TMPDIR/krisp_3.13.12_arm64.pkg\" -target /\nrelaunch_application 'ai.krisp.krispMac'\n",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Filename casing mismatch between installer_url and install script.

The installer_url (line 9) references Krisp_3.13.12_arm64.pkg (capital K), but the install script hardcodes krisp_3.13.12_arm64.pkg (lowercase k) in the sudo installer -pkg command. On case-sensitive APFS volumes — which are supported and sometimes used on macOS — the installer will fail with a "file not found" error because the downloaded file preserves the URL's casing.

The script derives TMPDIR from $INSTALLER_PATH but then ignores $INSTALLER_PATH and reconstructs the path with a hardcoded, differently-cased filename. Using $INSTALLER_PATH directly would eliminate both the casing risk and the fragility of hardcoding version-specific filenames.

🔧 Proposed fix: use $INSTALLER_PATH directly
- sudo installer -pkg "$TMPDIR/krisp_3.13.12_arm64.pkg" -target /
+ sudo installer -pkg "$INSTALLER_PATH" -target /

If the hardcoded pattern must be preserved for other reasons, at minimum match the URL's casing:

- sudo installer -pkg "$TMPDIR/krisp_3.13.12_arm64.pkg" -target /
+ sudo installer -pkg "$TMPDIR/Krisp_3.13.12_arm64.pkg" -target /
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"refs": {
"ac635988": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# install pkg files\nquit_and_track_application 'ai.krisp.krispMac'\nsudo installer -pkg \"$TMPDIR/krisp_3.13.8_arm64.pkg\" -target /\nrelaunch_application 'ai.krisp.krispMac'\n",
"96f45265": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# install pkg files\nquit_and_track_application 'ai.krisp.krispMac'\nsudo installer -pkg \"$TMPDIR/krisp_3.13.12_arm64.pkg\" -target /\nrelaunch_application 'ai.krisp.krispMac'\n",
# install pkg files
quit_and_track_application 'ai.krisp.krispMac'
sudo installer -pkg "$INSTALLER_PATH" -target /
relaunch_application 'ai.krisp.krispMac'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/krisp/darwin.json` around lines 18 - 19, The
install flow has a filename casing mismatch between the downloaded package and
the hardcoded package path used in the script. Update the install command in the
Krisp shell script to use the existing INSTALLER_PATH-derived value instead of
reconstructing krisp_3.13.12_arm64.pkg, so it stays aligned with the
installer_url casing and avoids case-sensitive APFS failures. Keep the fix
localized to the script that defines TMPDIR and runs sudo installer, and ensure
the path comes from the same variable used by the download step.

@allenhouchins
allenhouchins merged commit 2a1f513 into main Jul 8, 2026
11 of 12 checks passed
@allenhouchins
allenhouchins deleted the fma-2607081228 branch July 8, 2026 14:15
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/adobe-dng-converter/darwin.json

=== Install // 5b77b60e -> f1e56d5b ===

--- /tmp/old.e3zJrk	2026-07-08 14:16:37.829512755 +0000
+++ /tmp/new.IhZPWO	2026-07-08 14:16:37.829512755 +0000
@@ -101,5 +101,5 @@
 hdiutil detach "$MOUNT_POINT" || true
 # install pkg files
 quit_and_track_application 'com.adobe.DNGConverter'
-sudo installer -pkg "$TMPDIR/DNGConverter_18_4.pkg" -target /
+sudo installer -pkg "$TMPDIR/DNGConverter_18_4_1.pkg" -target /
 relaunch_application 'com.adobe.DNGConverter'

=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/antigravity/darwin.json

=== Install Script (no changes) ===
=== Uninstall // d695eb0f -> 8838465b ===

--- /tmp/old.DzqMo5	2026-07-08 14:16:37.877510555 +0000
+++ /tmp/new.EMAxpY	2026-07-08 14:16:37.878510509 +0000
@@ -101,5 +101,7 @@
 trash $LOGGED_IN_USER '~/Library/Caches/com.google.antigravity'
 trash $LOGGED_IN_USER '~/Library/Caches/com.google.antigravity.ShipIt'
 trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.google.antigravity'
+trash $LOGGED_IN_USER '~/Library/Logs/Antigravity'
+trash $LOGGED_IN_USER '~/Library/Preferences/ByHost/com.google.antigravity.ShipIt.*.plist'
 trash $LOGGED_IN_USER '~/Library/Preferences/com.google.antigravity.plist'
 trash $LOGGED_IN_USER '~/Library/Saved Application State/com.google.Antigravity.savedState'

ee/maintained-apps/outputs/bitbox/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/capto/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/cursor/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/dropshare/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/fastmail/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/gitkraken/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/goland/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-chrome/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-chrome/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/google-gemini/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/krisp/darwin.json

=== Install // ac635988 -> 96f45265 ===

--- /tmp/old.E8cPsl	2026-07-08 14:16:38.231495431 +0000
+++ /tmp/new.PxQFPU	2026-07-08 14:16:38.231495431 +0000
@@ -96,5 +96,5 @@
 
 # install pkg files
 quit_and_track_application 'ai.krisp.krispMac'
-sudo installer -pkg "$TMPDIR/krisp_3.13.8_arm64.pkg" -target /
+sudo installer -pkg "$TMPDIR/krisp_3.13.12_arm64.pkg" -target /
 relaunch_application 'ai.krisp.krispMac'

=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/melodics/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/notion/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/phpstorm/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/postman/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/postman/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/readest/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rightfont/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rive/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/rubymine/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/sequel-ace/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/tableplus/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/unity-hub/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/viscosity/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/viscosity/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/visual-studio-code/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/webstorm/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/windows-app/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants