Update Fleet-maintained apps - #49965
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
Contributor
Script Diff Resultsee/maintained-apps/outputs/elgato-control-center/darwin.json=== Install Script (no changes) ===
=== Uninstall // 01138a65 -> 1c0989fd ===
--- /tmp/old.7omvST 2026-07-27 09:11:07.088807596 +0000
+++ /tmp/new.k27OYW 2026-07-27 09:11:07.088807596 +0000
@@ -95,8 +95,11 @@
quit_application 'com.corsair.ControlCenter'
sudo rm -rf "$APPDIR/Elgato Control Center.app"
trash $LOGGED_IN_USER '~/Library/Application Scripts/com.corsair.ControlCenterLauncher'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.corsair.controlcenter.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/com.corsair.ControlCenter'
+trash $LOGGED_IN_USER '~/Library/Application Support/Elgato Control Center'
trash $LOGGED_IN_USER '~/Library/Caches/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Caches/com.plausiblelabs.crashreporter.data/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Containers/com.corsair.ControlCenterLauncher'
+trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Preferences/com.corsair.ControlCenter.plist'ee/maintained-apps/outputs/firefox@nightly/darwin.json=== Install Script (no changes) ===
=== Uninstall // d7c711ad -> 0661f848 ===
--- /tmp/old.IYRTT3 2026-07-27 09:11:07.156807519 +0000
+++ /tmp/new.CdaMpk 2026-07-27 09:11:07.156807519 +0000
@@ -65,5 +65,6 @@
trash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'
trash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'
trash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'
+trash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.nightly.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'
trash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'ee/maintained-apps/outputs/kiro/darwin.json=== Install Script (no changes) ===
=== Uninstall // b5d79db0 -> 4678d87f ===
--- /tmp/old.dRdtJd 2026-07-27 09:11:07.210807458 +0000
+++ /tmp/new.sd5YNS 2026-07-27 09:11:07.210807458 +0000
@@ -54,6 +54,8 @@
sudo rm -rf "$APPDIR/Kiro.app"
sudo rm -rf 'kiro'
+sudo rmdir '~/.kiro'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Kiro'
trash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'ee/maintained-apps/outputs/marked-app/darwin.json=== Install Script (no changes) ===
=== Uninstall // 9e4b9fca -> 57b4bcf2 ===
--- /tmp/old.5mwwtg 2026-07-27 09:11:07.269807391 +0000
+++ /tmp/new.EuwnC1 2026-07-27 09:11:07.270807391 +0000
@@ -94,10 +94,15 @@
quit_application 'com.brettterpstra.marked'
sudo rm -rf "$APPDIR/Marked.app"
+trash $LOGGED_IN_USER '~/Library/Application Scripts/com.brettterpstra.marked.Share'
trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.brettterpstra.marked.sfl*'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Application Support/Marked'
trash $LOGGED_IN_USER '~/Library/Caches/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Caches/Marked'
+trash $LOGGED_IN_USER '~/Library/Containers/com.brettterpstra.marked.Share'
+trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Logs/Marked'
trash $LOGGED_IN_USER '~/Library/Preferences/com.brettterpstra.marked.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/com.brettterpstra.marked.savedState'
+trash $LOGGED_IN_USER '~/Library/WebKit/com.brettterpstra.marked'ee/maintained-apps/outputs/mellel/darwin.json=== Install Script (no changes) ===
=== Uninstall // 7a83c8df -> 0ed774a5 ===
--- /tmp/old.HQHzKw 2026-07-27 09:11:07.322807332 +0000
+++ /tmp/new.vZn53u 2026-07-27 09:11:07.323807331 +0000
@@ -54,6 +54,7 @@
sudo rm -rf "$APPDIR/Mellel 6.app"
trash $LOGGED_IN_USER '~/Library/Application Scripts/com.redlex.mellel'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.redlex.mellel6.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/com.redlex.mellel6'
trash $LOGGED_IN_USER '~/Library/Application Support/Mellel 6'
trash $LOGGED_IN_USER '~/Library/Caches/com.redlex.mellel6'ee/maintained-apps/outputs/melodics/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/opencode-desktop/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/purevpn/darwin.json=== Install Script (no changes) ===
=== Uninstall // c8aad552 -> d713dfe8 ===
--- /tmp/old.iMDcOK 2026-07-27 09:11:07.440807198 +0000
+++ /tmp/new.GwDgcf 2026-07-27 09:11:07.441807197 +0000
@@ -161,9 +161,12 @@
quit_application 'com.purevpn.app.mac'
remove_pkg_files 'com.purevpn.mac.installer'
forget_pkg 'com.purevpn.mac.installer'
+trash $LOGGED_IN_USER '~/Library/Application Scripts/4H849Z7V2K.com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/Application Support/com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/Caches/com.purevpn.app.mac'
+trash $LOGGED_IN_USER '~/Library/Group Containers/4H849Z7V2K.com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.purevpn.app.mac.binarycookies'
trash $LOGGED_IN_USER '~/Library/Preferences/com.purevpn.app.mac.plist'
+trash $LOGGED_IN_USER '~/Library/Preferences/group.com.purevpn.app.mac.firebase.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/com.purevpn.app.mac.savedState'ee/maintained-apps/outputs/reqable/darwin.json=== Install Script (no changes) ===
=== Uninstall // 3319d75e -> 5fd65159 ===
--- /tmp/old.20aT9J 2026-07-27 09:11:07.488807144 +0000
+++ /tmp/new.OYmD02 2026-07-27 09:11:07.488807144 +0000
@@ -53,5 +53,6 @@
}
sudo rm -rf "$APPDIR/Reqable.app"
+trash $LOGGED_IN_USER '~/Library/Application Support/com.reqable.macosx'
trash $LOGGED_IN_USER '~/Library/Caches/Reqable'
trash $LOGGED_IN_USER '~/Library/Preferences/com.reqable.macosx.plist'ee/maintained-apps/outputs/rize/darwin.json=== Install Script (no changes) ===
=== Uninstall // 8f8ad201 -> fe9839a4 ===
--- /tmp/old.GgogJl 2026-07-27 09:11:07.534807092 +0000
+++ /tmp/new.1RCUxx 2026-07-27 09:11:07.534807092 +0000
@@ -53,6 +53,7 @@
}
sudo rm -rf "$APPDIR/Rize.app"
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.rize.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Rize'
trash $LOGGED_IN_USER '~/Library/Caches/io.rize'
trash $LOGGED_IN_USER '~/Library/Caches/io.rize.ShipIt'ee/maintained-apps/outputs/screen-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/voiceink/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/zed/darwin.json=== Install Script (no changes) ===
=== Uninstall // 9e70631b -> 0436e2d8 ===
--- /tmp/old.PAkBsx 2026-07-27 09:11:07.668806941 +0000
+++ /tmp/new.t4QB3V 2026-07-27 09:11:07.668806941 +0000
@@ -92,9 +92,9 @@
fi
}
+quit_application 'dev.zed.Zed'
sudo rm -rf "$APPDIR/Zed.app"
sudo rm -rf 'zed'
-quit_application 'dev.zed.Zed'
trash $LOGGED_IN_USER '~/.config/zed'
trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.zed.zed.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Zed' |
Contributor
WalkthroughUpdated maintained macOS application manifests with newer installer versions and checksums for Firefox Nightly, Melodics, OpenCode, Screen Studio, and VoiceInk. Updated uninstall script references for Elgato Control Center, Kiro, Marked, Mellel, PureVPN, Reqable, Rize, and Zed, including additional user-data cleanup and an adjusted Zed uninstall order. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/firefox`@nightly/darwin.json:
- Line 19: Update the three rmdir commands in the uninstall script to replace
single-quoted ~/ paths with paths explicitly rooted at /Users/$LOGGED_IN_USER,
preserving quoting for spaces and ensuring the user’s Mozilla directories are
removed.
In `@ee/maintained-apps/outputs/kiro/darwin.json`:
- Line 20: Fix the ~/.kiro cleanup command near the existing sudo removals so it
targets the logged-in user’s actual home directory instead of the literal
"~/.kiro" path. Reuse the existing trash helper with LOGGED_IN_USER or
explicitly expand the path, while preserving the surrounding cleanup behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ce5a1e87-1efd-4e44-a89a-f45e3faa0dff
📒 Files selected for processing (13)
ee/maintained-apps/outputs/elgato-control-center/darwin.jsonee/maintained-apps/outputs/firefox@nightly/darwin.jsonee/maintained-apps/outputs/kiro/darwin.jsonee/maintained-apps/outputs/marked-app/darwin.jsonee/maintained-apps/outputs/mellel/darwin.jsonee/maintained-apps/outputs/melodics/darwin.jsonee/maintained-apps/outputs/opencode-desktop/darwin.jsonee/maintained-apps/outputs/purevpn/darwin.jsonee/maintained-apps/outputs/reqable/darwin.jsonee/maintained-apps/outputs/rize/darwin.jsonee/maintained-apps/outputs/screen-studio/darwin.jsonee/maintained-apps/outputs/voiceink/darwin.jsonee/maintained-apps/outputs/zed/darwin.json
| "refs": { | ||
| "418c9331": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'org.mozilla.nightly'\nif [ -d \"$APPDIR/Firefox Nightly.app\" ]; then\n\tsudo mv \"$APPDIR/Firefox Nightly.app\" \"$TMPDIR/Firefox Nightly.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/Firefox Nightly.app\" \"$APPDIR\"\nrelaunch_application 'org.mozilla.nightly'\n", | ||
| "d7c711ad": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Firefox Nightly.app\"\nsudo rmdir '~/Library/Application Support/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla/updates'\nsudo rmdir '~/Library/Caches/Mozilla/updates/Applications'\ntrash $LOGGED_IN_USER '/Library/Logs/DiagnosticReports/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/org.mozilla.firefox.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/CrashReporter/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'\ntrash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'\n" | ||
| "0661f848": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Firefox Nightly.app\"\nsudo rmdir '~/Library/Application Support/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla/updates'\nsudo rmdir '~/Library/Caches/Mozilla/updates/Applications'\ntrash $LOGGED_IN_USER '/Library/Logs/DiagnosticReports/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/org.mozilla.firefox.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/CrashReporter/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.nightly.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'\ntrash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'\n", |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix quoted home-directory paths in the uninstall script.
Because ~ is inside single quotes, these rmdir commands operate on a literal ~/... path and leave the user’s Mozilla directories behind. Expand the path explicitly using /Users/$LOGGED_IN_USER/... (or an equivalent quoted variable).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/firefox`@nightly/darwin.json at line 19, Update
the three rmdir commands in the uninstall script to replace single-quoted ~/
paths with paths explicitly rooted at /Users/$LOGGED_IN_USER, preserving quoting
for spaces and ensuring the user’s Mozilla directories are removed.
| "refs": { | ||
| "28c3d1eb": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'dev.kiro.desktop'\nif [ -d \"$APPDIR/Kiro.app\" ]; then\n\tsudo mv \"$APPDIR/Kiro.app\" \"$TMPDIR/Kiro.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/Kiro.app\" \"$APPDIR\"\nrelaunch_application 'dev.kiro.desktop'\nmkdir -p .\n/bin/ln -h -f -s -- \"$APPDIR/Kiro.app/Contents/Resources/app/bin/code\" \"kiro\"\n", | ||
| "b5d79db0": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" | ||
| "4678d87f": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\nsudo rmdir '~/.kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "File and relevant content:"
sed -n '1,40p' ee/maintained-apps/outputs/kiro/darwin.json | cat -n
echo
echo "Raw JSON line 20:"
python3 - <<'PY'
import json
from pathlib import Path
p=Path("ee/maintained-apps/outputs/kiro/darwin.json")
data=json.loads(p.read_text())
print(data.get("content", ""))
PY
echo
echo "Search for similar rmdir/twirl cleanup patterns:"
rg -n "rmdir '~/.kiro'|\brmdir\b|trash" ee/maintained-apps/outputs/kiro/darwin.jsonRepository: fleetdm/fleet
Length of output: 9352
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Behavioral probe: demonstrate Bash expansion for quoted vs unquoted tilde in a standalone non-repository context.
bash -c '
APPDIR="/Applications/"
LOGGED_IN_USER=$(id -un)
echo "loginshell user=$LOGGED_IN_USER"
echo >&2 "$APPDIR"
echo >&2 "$LOGGED_IN_USER"
echo "quoted-tilde expansion probe:"
bash -c 'echo "~/.kiro"; ls -la ~/Library 2>/dev/null | head -5' >&2
'Repository: fleetdm/fleet
Length of output: 306
🏁 Script executed:
#!/bin/bash
set -euo pipefail
tmp="$(mktemp -d)"
echo "quoting behavior:"
# Run Bash from outside this repo under an expected home so the unquoted tilde probe resolves normally.
BASH_HOME="$tmp" HOME="$tmp" bash -c '
echo "$BASH_HOME unquoted =>"; ls -la "$BASH_HOME" 2>&1 | sed -n "1,4p"
echo "$BASH_HOME quoted =>"; ls -la "'"$tmp"'/~" 2>&1 | sed -n "1,4p"
'
echo "repo script line with literal quoted-tilde rmdir:"
rg -n "sudo rmdir '~/.kiro'" ee/maintained-apps/outputs/kiro/darwin.jsonRepository: fleetdm/fleet
Length of output: 2657
Fix the ~/.kiro cleanup path.
sudo rmdir '~/.kiro' passes the literal literal ~/.kiro path to rmdir, so the logged-in user’s ~/.kiro directory is not removed. Use the existing trash helper or expand the path explicitly.
Proposed fix
- sudo rmdir '~/.kiro'
+ trash "$LOGGED_IN_USER" '~/.kiro'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "4678d87f": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\nsudo rmdir '~/.kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" | |
| "4678d87f": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\ntrash \"$LOGGED_IN_USER\" '~/.kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/kiro/darwin.json` at line 20, Fix the ~/.kiro
cleanup command near the existing sudo removals so it targets the logged-in
user’s actual home directory instead of the literal "~/.kiro" path. Reuse the
existing trash helper with LOGGED_IN_USER or explicitly expand the path, while
preserving the surrounding cleanup behavior.
Contributor
|
Closing in favor of #49974. |
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit