Skip to content

Remove Captin software icon - #50277

Merged
allenhouchins merged 1 commit into
mainfrom
remove-captin-icon
Jul 31, 2026
Merged

Remove Captin software icon#50277
allenhouchins merged 1 commit into
mainfrom
remove-captin-icon

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jul 31, 2026

Copy link
Copy Markdown
Member

Related issue: N/A

What this does

Removes the Captin software icon: the Captin.tsx fallback icon component and its
SOFTWARE_NAME_TO_ICON_MAP entry.

Captin is deprecated and is being removed as a Fleet-maintained app. Its manifest fails
the FMA validator because the download at the pinned URL now installs 2.0.1 while
Homebrew still declares 1.3.1:

level=INFO msg="Looking for app: Captin, version: 1.3.1" app=Captin
level=INFO msg="Found app: 'Captin' at /Applications/Captin.app, Version: 2.0.1, Bundled Version: 203"
level=ERROR msg="App version '1.3.1' was not found by osquery" app=Captin

Split out of the FMA removal so the frontend change can be reviewed on its own.

Note

Merge order. The FMA removal (input, output manifest, and apps.json entry) is in a
separate PR. Merging this one first leaves the Captin FMA without a fallback icon until
that PR lands, so it should merge after — or at the same time as — the FMA removal.

Verified nothing else references Captin after the removal. The one remaining mention in
the repo is a row in cmd/osquery-perf/software-library/software.sql, which is a
load-test software inventory corpus rather than an FMA reference, so it is left alone.

Checklist for submitter

  • QA'd all new/changed functionality manually

No changes file: this is not a user-visible change on its own, and matches how other FMA
catalog/icon PRs ship (e.g. #50028, #50024).

Summary by CodeRabbit

  • Bug Fixes
    • Removed the obsolete Captin icon from the software listings.
    • Prevented the retired icon from appearing in software name mappings.

Captin is deprecated and is being removed as a Fleet-maintained app, so its
fallback icon component and SOFTWARE_NAME_TO_ICON_MAP entry are no longer
referenced by anything.
@allenhouchins
allenhouchins requested a review from a team as a code owner July 31, 2026 04:01
Copilot AI review requested due to automatic review settings July 31, 2026 04:01
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ea8bbb5-65fc-4abc-8335-39a1f8a5ac3f

📥 Commits

Reviewing files that changed from the base of the PR and between 3660b54 and cb445b2.

📒 Files selected for processing (2)
  • frontend/pages/SoftwarePage/components/icons/Captin.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts
💤 Files with no reviewable changes (2)
  • frontend/pages/SoftwarePage/components/icons/index.ts
  • frontend/pages/SoftwarePage/components/icons/Captin.tsx

Walkthrough

Removed the obsolete Captin SVG icon component. Removed its import from the icon registry. Removed the "captin" software-name mapping. Other icon mappings remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of the deprecated Captin software icon.
Description check ✅ Passed The description explains the change, rationale, merge-order dependency, testing status, and why no changes file is needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-captin-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated Captin software icon from Fleet’s Software page icon set by deleting the Captin fallback icon component and removing its entry from the icon map. This keeps the frontend icon catalog aligned with the ongoing removal of Captin as a Fleet-maintained app.

Changes:

  • Removed the Captin icon component (Captin.tsx).
  • Removed the Captin import and captin entry from SOFTWARE_NAME_TO_ICON_MAP.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/pages/SoftwarePage/components/icons/index.ts Removes the Captin import and captin → icon mapping entry.
frontend/pages/SoftwarePage/components/icons/Captin.tsx Deletes the Captin SVG/icon component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.17%. Comparing base (3660b54) to head (cb445b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #50277    +/-   ##
========================================
  Coverage   68.17%   68.17%            
========================================
  Files        3935     3934     -1     
  Lines      250985   250983     -2     
  Branches    13406    13248   -158     
========================================
- Hits       171099   171098     -1     
  Misses      64551    64551            
+ Partials    15335    15334     -1     
Flag Coverage Δ
frontend 61.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins merged commit 347fa6c into main Jul 31, 2026
28 checks passed
@allenhouchins
allenhouchins deleted the remove-captin-icon branch July 31, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants