Remove Captin software icon - #50277
Conversation
Captin is deprecated and is being removed as a Fleet-maintained app, so its fallback icon component and SOFTWARE_NAME_TO_ICON_MAP entry are no longer referenced by anything.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughRemoved the obsolete 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated Captin software icon from Fleet’s Software page icon set by deleting the Captin fallback icon component and removing its entry from the icon map. This keeps the frontend icon catalog aligned with the ongoing removal of Captin as a Fleet-maintained app.
Changes:
- Removed the
Captinicon component (Captin.tsx). - Removed the
Captinimport andcaptinentry fromSOFTWARE_NAME_TO_ICON_MAP.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Removes the Captin import and captin → icon mapping entry. |
| frontend/pages/SoftwarePage/components/icons/Captin.tsx | Deletes the Captin SVG/icon component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50277 +/- ##
========================================
Coverage 68.17% 68.17%
========================================
Files 3935 3934 -1
Lines 250985 250983 -2
Branches 13406 13248 -158
========================================
- Hits 171099 171098 -1
Misses 64551 64551
+ Partials 15335 15334 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue: N/A
What this does
Removes the Captin software icon: the
Captin.tsxfallback icon component and itsSOFTWARE_NAME_TO_ICON_MAPentry.Captin is deprecated and is being removed as a Fleet-maintained app. Its manifest fails
the FMA validator because the download at the pinned URL now installs 2.0.1 while
Homebrew still declares 1.3.1:
Split out of the FMA removal so the frontend change can be reviewed on its own.
Note
Merge order. The FMA removal (input, output manifest, and
apps.jsonentry) is in aseparate PR. Merging this one first leaves the Captin FMA without a fallback icon until
that PR lands, so it should merge after — or at the same time as — the FMA removal.
Verified nothing else references
Captinafter the removal. The one remaining mention inthe repo is a row in
cmd/osquery-perf/software-library/software.sql, which is aload-test software inventory corpus rather than an FMA reference, so it is left alone.
Checklist for submitter
No changes file: this is not a user-visible change on its own, and matches how other FMA
catalog/icon PRs ship (e.g. #50028, #50024).
Summary by CodeRabbit