Skip to content

Bump frozen Adobe Acrobat Pro (macOS) to installer-delivered 26.001.21691 - #50370

Merged
allenhouchins merged 2 commits into
mainfrom
fma-unfreeze/adobe-acrobat-pro-darwin
Aug 1, 2026
Merged

Bump frozen Adobe Acrobat Pro (macOS) to installer-delivered 26.001.21691#50370
allenhouchins merged 2 commits into
mainfrom
fma-unfreeze/adobe-acrobat-pro-darwin

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Aug 1, 2026

Copy link
Copy Markdown
Member

Automated unfreeze probe, revised after validation. The full unfreeze failed: the Homebrew cask
reports 26.001.21771 (tracking Adobe's updater manifest), but Adobe's version-less web installer
DMG still delivers 26.001.21691, so the validator's post-install osquery check failed at
26.001.21771 — the same installer-lags-manifest behavior that caused the original freeze.

This PR instead pins the output manifest to 26.001.21691 (the version the DMG actually installs,
confirmed by the 2026-08-01 validator run) and keeps "frozen": true so the nightly ingester
doesn't bump it back to the cask version.

Frozen since: 2025-12-02 (#36609 — "product updated but installer was not, causing validation issues")
Version: 26.001.21662 -> 26.001.21691 (cask claims 26.001.21771; installer not updated yet)

Note: the regenerated manifest also picks up a newer uninstall_script_ref, because the frozen
output missed the script-template updates that landed on main while it was pinned.

Draft until validation reports. Merge only if the FMA checks are green and the validate shard
actually ran for this slug.

Related issue: NA

Checklist for submitter

  • QA'd all new/changed functionality manually — pending CI validation, see above.

Generated by Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the Adobe Acrobat Pro macOS package to version 26.001.21691.
    • Improved uninstallation handling for launch services while retaining existing cleanup behavior.

Removes "frozen": true and regenerates the output manifest so
test-fma-darwin-pr-only can validate adobe-acrobat-pro/darwin at its
current upstream version.

Claude-Session: https://claude.ai/code/session_01EBxhs5D65LRUwCEJejBLJH
Copilot AI review requested due to automatic review settings August 1, 2026 02:03
fleet-release
fleet-release previously approved these changes Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/adobe-acrobat-pro/darwin.json

=== Install Script (no changes) ===
=== Uninstall // c89ac073 -> 31c20531 ===

--- /tmp/old.Du68pH	2026-08-01 02:05:02.771429468 +0000
+++ /tmp/new.0Xvg5O	2026-08-01 02:05:02.771429468 +0000
@@ -78,38 +78,63 @@
 
   echo "Removing launchctl service ${service}"
 
-  for should_sudo in "${booleans[@]}"; do
-    plist_status=$(launchctl list "${service}" 2>/dev/null)
-
-    if [[ $plist_status == \{* ]]; then
-      if [[ $should_sudo == "true" ]]; then
-        sudo launchctl remove "${service}"
-      else
-        launchctl remove "${service}"
-      fi
-      sleep 1
+  # A wildcard label can't be used with launchctl or as a plist name, so expand
+  # it to the labels of currently loaded services that match the pattern.
+  local services=("$service")
+  if [[ "$service" == *"*"* ]]; then
+    local regex
+    # Escape regex metacharacters, turn '*' into '.*', and anchor the pattern so
+    # it matches a full label rather than a substring.
+    regex=$(printf '%s' "$service" | sed -e 's/[][(){}.^$+?|\\]/\\&/g' -e 's/\*/.*/g')
+    regex="^${regex}$"
+    services=()
+    local id
+    # Match every loaded job by label regardless of PID; launchctl list reports
+    # loaded-but-not-running jobs with a "-" in the PID column.
+    while read -r _ _ id; do
+      [[ "$id" =~ $regex ]] && services+=("$id")
+    done < <(launchctl list 2>/dev/null | tail -n +2)
+    if [[ ${#services[@]} -eq 0 ]]; then
+      echo "No loaded launchctl service matches ${service}"
+      return
     fi
+  fi
 
-    paths=(
-      "/Library/LaunchAgents/${service}.plist"
-      "/Library/LaunchDaemons/${service}.plist"
-    )
-
-    # if not using sudo, prepend the home directory to the paths
-    if [[ $should_sudo == "false" ]]; then
-      for i in "${!paths[@]}"; do
-        paths[i]="${HOME}${paths[i]}"
-      done
-    fi
+  local service_label
+  for service_label in "${services[@]}"; do
+    for should_sudo in "${booleans[@]}"; do
+      plist_status=$(launchctl list "${service_label}" 2>/dev/null)
 
-    for path in "${paths[@]}"; do
-      if [[ -e "$path" ]]; then
+      if [[ $plist_status == \{* ]]; then
         if [[ $should_sudo == "true" ]]; then
-          sudo rm -f -- "$path"
+          sudo launchctl remove "${service_label}"
         else
-          rm -f -- "$path"
+          launchctl remove "${service_label}"
         fi
+        sleep 1
       fi
+
+      paths=(
+        "/Library/LaunchAgents/${service_label}.plist"
+        "/Library/LaunchDaemons/${service_label}.plist"
+      )
+
+      # if not using sudo, prepend the home directory to the paths
+      if [[ $should_sudo == "false" ]]; then
+        for i in "${!paths[@]}"; do
+          paths[i]="${HOME}${paths[i]}"
+        done
+      fi
+
+      for path in "${paths[@]}"; do
+        if [[ -e "$path" ]]; then
+          if [[ $should_sudo == "true" ]]; then
+            sudo rm -f -- "$path"
+          else
+            rm -f -- "$path"
+          fi
+        fi
+      done
     done
   done
 }

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Unfreezes the macOS Fleet-maintained app (FMA) for Adobe Acrobat Pro by removing the frozen pin from the Homebrew input and regenerating the darwin output manifest to track the current upstream version.

Changes:

  • Remove "frozen": true from adobe-acrobat-pro/darwin input.
  • Regenerate the darwin output manifest to bump the tracked version to 26.001.21771.
  • Update the output manifest to reference the newer uninstall script template revision.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ee/maintained-apps/outputs/adobe-acrobat-pro/darwin.json Bumps version/probe query to 26.001.21771 and updates uninstall script ref in the regenerated output manifest.
ee/maintained-apps/inputs/homebrew/adobe-acrobat-pro.json Removes the freeze flag so the darwin FMA can validate against current upstream again.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The Homebrew cask reports 26.001.21771 (from Adobe's updater manifest),
but Adobe's version-less web installer DMG still delivers 26.001.21691,
so validation fails at 26.001.21771. Pin the manifest to 26.001.21691
(the version the DMG actually installs, per the 2026-08-01 validator
run) and restore "frozen": true so the nightly ingester doesn't bump it
back to the cask version. This still advances the frozen version from
26.001.21662 and picks up the regenerated uninstall script.
Copilot AI review requested due to automatic review settings August 1, 2026 02:30
@allenhouchins allenhouchins changed the title Unfreeze Adobe Acrobat Pro (macOS) Bump frozen Adobe Acrobat Pro (macOS) to installer-delivered 26.001.21691 Aug 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@allenhouchins
allenhouchins marked this pull request as ready for review August 1, 2026 02:37
@allenhouchins
allenhouchins merged commit 1dafb29 into main Aug 1, 2026
17 of 18 checks passed
@allenhouchins
allenhouchins deleted the fma-unfreeze/adobe-acrobat-pro-darwin branch August 1, 2026 02:37
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e745e0e-07f8-452b-abf2-f964f2ff7330

📥 Commits

Reviewing files that changed from the base of the PR and between 45abf8c and 9745f6d.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/adobe-acrobat-pro/darwin.json

Walkthrough

Adobe Acrobat Pro’s macOS package version and patched-version query now target 26.001.21691. The manifest references uninstall script 31c20531 instead of c89ac073. The new uninstall script matches loaded launchctl services with wildcards before removing services and plist files. The installer script remains unchanged.

Possibly related PRs

  • fleetdm/fleet#50372: Updates a macOS app manifest with a newer version and wildcard launchctl cleanup.
  • fleetdm/fleet#49784: Updates maintained application metadata and patched-version queries.
  • fleetdm/fleet#49989: Updates maintained application metadata and uninstall-script references.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-unfreeze/adobe-acrobat-pro-darwin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

allenhouchins added a commit that referenced this pull request Aug 3, 2026
Automated unfreeze probe. Removes `"frozen": true` and regenerates the
output manifest so
`test-fma-darwin-pr-only` can validate `adobe-acrobat-pro/darwin` at its
current upstream version.

Frozen since: 2026-06-23 (#48089, automated FMA update run)
Version: 26.001.21691 -> 26.001.21771

Upstream Homebrew reports 26.001.21771, newer than the pinned
26.001.21691 that #50370 set from the
delivered installer, so this is a genuine forward bump rather than a
regression. The cask uses a
stable "latest" download URL with `sha256: no_check`, so the regenerated
diff is version and
`patched` query only.

Draft until validation reports. Merge only if the FMA checks are green
and the validate shard
actually ran for this slug.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** NA

# Checklist for submitter

- [x] QA'd all new/changed functionality manually — pending CI
validation, see above.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01LvsXk65MD2s93jeGJuHAk5)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants