Update Fleet-maintained apps - #50657
Conversation
Generated automatically with cmd/maintained-apps.
Script Diff Resultsee/maintained-apps/outputs/krita/darwin.json=== Install Script (no changes) ===
=== Uninstall // 7b9f27dc -> 3947b0f0 ===
--- /tmp/old.3Jqncx 2026-08-06 02:54:49.890575507 +0000
+++ /tmp/new.Sr7E0S 2026-08-06 02:54:49.890575507 +0000
@@ -52,8 +52,11 @@
fi
}
-sudo rm -rf "$APPDIR/krita.app"
-trash $LOGGED_IN_USER '~/Library/Application Support/krita'
+sudo rm -rf "$APPDIR/Krita.app"
+trash $LOGGED_IN_USER '~/Library/Application Scripts/org.krita.*'
+trash $LOGGED_IN_USER '~/Library/Application Support/krita*'
+trash $LOGGED_IN_USER '~/Library/Caches/krita'
+trash $LOGGED_IN_USER '~/Library/Containers/org.krita.*'
trash $LOGGED_IN_USER '~/Library/Preferences/kritadisplayrc'
trash $LOGGED_IN_USER '~/Library/Preferences/kritarc'
trash $LOGGED_IN_USER '~/Library/Saved Application State/org.krita.savedState' |
WalkthroughThe Krita macOS manifest now references uninstall script Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/krita/darwin.json`:
- Line 11: Update the generated uninstall source referenced by the Krita
manifest’s uninstall_script_ref so it removes the installed bundle using the
exact lowercase “krita.app” casing from the cdb966e7 install script, then
regenerate the manifest through cmd/maintained-apps.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5326150e-5e46-4c89-9aec-0a281416dd90
📒 Files selected for processing (1)
ee/maintained-apps/outputs/krita/darwin.json
| "installer_url": "https://download.kde.org/stable/krita/5.3.3/krita-5.3.3-signed.dmg", | ||
| "install_script_ref": "cdb966e7", | ||
| "uninstall_script_ref": "7b9f27dc", | ||
| "uninstall_script_ref": "3947b0f0", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the installed bundle’s actual casing.
3947b0f0 removes /Applications/Krita.app, but the cdb966e7 install script installs /Applications/krita.app. On a case-sensitive macOS volume, uninstall leaves the application installed.
Update the generated uninstall source used by cmd/maintained-apps, then regenerate this manifest.
Proposed fix
-sudo rm -rf "$APPDIR/Krita.app"
+sudo rm -rf "$APPDIR/krita.app"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/krita/darwin.json` at line 11, Update the
generated uninstall source referenced by the Krita manifest’s
uninstall_script_ref so it removes the installed bundle using the exact
lowercase “krita.app” casing from the cdb966e7 install script, then regenerate
the manifest through cmd/maintained-apps.
|
Closing in favor of #50662. |
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit