Skip to content

Update Fleet-maintained apps - #50657

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2608060249
Closed

Update Fleet-maintained apps#50657
fleet-release wants to merge 1 commit into
mainfrom
fma-2608060249

Conversation

@fleet-release

@fleet-release fleet-release commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Bug Fixes
    • Improved the Krita macOS uninstall process to remove the application and related support files, caches, scripts, and container data.
    • Continued cleanup of Krita preferences and saved-state information during uninstall.

Generated automatically with cmd/maintained-apps.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/krita/darwin.json

=== Install Script (no changes) ===
=== Uninstall // 7b9f27dc -> 3947b0f0 ===

--- /tmp/old.3Jqncx	2026-08-06 02:54:49.890575507 +0000
+++ /tmp/new.Sr7E0S	2026-08-06 02:54:49.890575507 +0000
@@ -52,8 +52,11 @@
   fi
 }
 
-sudo rm -rf "$APPDIR/krita.app"
-trash $LOGGED_IN_USER '~/Library/Application Support/krita'
+sudo rm -rf "$APPDIR/Krita.app"
+trash $LOGGED_IN_USER '~/Library/Application Scripts/org.krita.*'
+trash $LOGGED_IN_USER '~/Library/Application Support/krita*'
+trash $LOGGED_IN_USER '~/Library/Caches/krita'
+trash $LOGGED_IN_USER '~/Library/Containers/org.krita.*'
 trash $LOGGED_IN_USER '~/Library/Preferences/kritadisplayrc'
 trash $LOGGED_IN_USER '~/Library/Preferences/kritarc'
 trash $LOGGED_IN_USER '~/Library/Saved Application State/org.krita.savedState'

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The Krita macOS manifest now references uninstall script 3947b0f0 instead of 7b9f27dc. The updated script removes the case-sensitive Krita.app bundle and matching application scripts, support files, caches, and containers. It retains cleanup for preferences and saved-state data.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the general purpose but omits the related issue, checklist, and testing information required by the template. Add the related issue and complete or remove the applicable checklist and testing sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the update to Fleet-maintained app data.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2608060249

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/krita/darwin.json`:
- Line 11: Update the generated uninstall source referenced by the Krita
manifest’s uninstall_script_ref so it removes the installed bundle using the
exact lowercase “krita.app” casing from the cdb966e7 install script, then
regenerate the manifest through cmd/maintained-apps.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5326150e-5e46-4c89-9aec-0a281416dd90

📥 Commits

Reviewing files that changed from the base of the PR and between 600fbf4 and a69aff1.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/krita/darwin.json

"installer_url": "https://download.kde.org/stable/krita/5.3.3/krita-5.3.3-signed.dmg",
"install_script_ref": "cdb966e7",
"uninstall_script_ref": "7b9f27dc",
"uninstall_script_ref": "3947b0f0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use the installed bundle’s actual casing.

3947b0f0 removes /Applications/Krita.app, but the cdb966e7 install script installs /Applications/krita.app. On a case-sensitive macOS volume, uninstall leaves the application installed.

Update the generated uninstall source used by cmd/maintained-apps, then regenerate this manifest.

Proposed fix
-sudo rm -rf "$APPDIR/Krita.app"
+sudo rm -rf "$APPDIR/krita.app"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/krita/darwin.json` at line 11, Update the
generated uninstall source referenced by the Krita manifest’s
uninstall_script_ref so it removes the installed bundle using the exact
lowercase “krita.app” casing from the cdb966e7 install script, then regenerate
the manifest through cmd/maintained-apps.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #50662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants