only include policies in device endpoints for premium users - #6077
Merged
Conversation
roperzh
commented
Jun 3, 2022
roperzh
commented
Jun 3, 2022
juan-fdz-hawa
previously approved these changes
Jun 3, 2022
michalnicp
suggested changes
Jun 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #6077 +/- ##
=======================================
Coverage 59.16% 59.17%
=======================================
Files 366 366
Lines 33972 33986 +14
=======================================
+ Hits 20101 20112 +11
- Misses 11839 11846 +7
+ Partials 2032 2028 -4
Continue to review full report at Codecov.
|
gillespi314
reviewed
Jun 6, 2022
This was referenced Jun 6, 2022
michalnicp
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes policy information from
GET /api/_version_/fleet/device/{token}from non-premium Fleet instances.Starting the server with
./build/fleet serve --dev --dev_licenseStarting the server with
./build/fleet serve --devThis doesn't break the UI (I also manually tested) because a license check is used before trying to display any data (nice!)
fleet/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx
Lines 281 to 289 in 3290eb5
cc: @gillespi314 do you think this makes sense?
Related to: #5806
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/and/ororbit/changes/).