Skip to content

v4.91.1

@georgekarrv georgekarrv tagged this 10 Sep 15:31
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** #51896

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.

## Details

Reverts the cherry-pick of #52338 ("Fix slow host software list query",
RC commit 99cceca9ab) from the 4.91.1 release candidate, and removes its
entry from the 4.91.1 changelog.

**Why:** the fix carries a database migration
(`AddHostVPPAndInHouseInstallsHostIndexes`, `20260902150237` on main).
Shipping it in 4.91.1 requires re-timestamping it on the RC to sort
before 4.92.0's first new migration (`20260810192005`), which in turn
requires a matching re-timestamp PR on main before 4.92.0 ships — the
`ADD INDEX` migration is not idempotent, so a timestamp mismatch would
break 4.91.1 → 4.92.0 upgrades. Dropping the fix from 4.91.1 avoids the
renumbering entirely; #51896 ships in 4.92.0 with its original migration
timestamp.

After this revert, 4.91.1 contains **no new migrations** relative to
4.91.0, and no migration renumbering is needed on main.

**Verified:**
- `go build` / `go vet` clean on `server/datastore/mysql`
- `TestMigrations` passes; migration chain ends at
`20260810160000_DedupeSoftwareChecksums` (same as 4.91.0 + earlier
picks)
- `TestSoftware/ListHostSoftware` passes against the restored query code
- `schema.sql` restored (seed list back to id 591, new indexes removed)

## Testing

- [x] Added/updated automated tests (existing tests cover the restored
code; the reverted commit's tests were removed with it)

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results (restores the code that shipped in 4.91.0; note the #51896
slow query remains present in 4.91.1, as in 4.91.0)

---------

Co-authored-by: test <test@test.com>
Assets 2
Loading