refactor(OME-52): containerized build, single-port serving#4
Merged
Conversation
…dead pages Remove the entire K8s proxy layer, multi-cluster model, and dead UI pages that were superseded by the Go backend. The frontend is now a thin shell that loads only the management plugin (Targets, Orchestration, Signing Keys). - Delete core-plugin entirely (Dashboard, ClusterListPage, ClusterDetailPage stubs) - Delete K8s client, informers, log streamer, and all K8s proxy routes from mock-server - Delete database layer (db.ts, seed.ts), WebSocket handler, auth middleware - Delete GrantAccessPage, passkey API, UserPreferencesContext, useInvalidationSocket - Remove AuthBanner, AuthMethodsPage, authState from management plugin - Remove ClusterSwitcher from masthead - Simplify AppLayout nav to flat list from navLayout (no hard-coded items) - Add redirect from / to first plugin page - Strip common package to essential types (User, PluginEntry, PluginRegistry) - Update CLAUDE.md to reflect current architecture Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…dynamic OIDC - Replace per-package Dockerfiles with single Dockerfile.web that builds all frontend assets (common -> plugins -> GUI -> merge) in a UBI9 container - Remove webpack-dev-server, serve commands, and all dev scripts — no host Node.js required, everything runs in containers via the POC repo - Namespace webpack chunks (shell/ vs plugins/) to prevent filename collisions when merging GUI and plugin builds into a single web/ directory - Per-plugin output directories (plugins/management/, plugins/routing/) - Dynamic OIDC config: fetch authority/clientId from /api/ui/config at runtime instead of hardcoding Keycloak settings - API paths: /v1/* (gRPC-gateway), /api/ui/* (UI config) — no Express proxy - Update README to reflect containerized build and single-port serving model Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…chitecture Delete packages replaced by Go backend: - packages/mock-servers — Express mock API (replaced by /api/ui/* endpoints) - packages/mock-cli-plugins — CLI remote plugins (CLI is now Go fleetctl) - packages/cli — Ink terminal CLI (replaced by Go fleetctl) Update e2e tests: - Port references 3000 → 8085 - Remove stale helpers/api.ts (old Express API calls) - Remove routing-plugin.spec.ts (depended on canvas pages) - Rewrite smoke test for current app (Targets, Orchestration, Signing Keys) - Remove webServer auto-start (no npm run dev) Clean up root package.json: - Remove unused deps: joi, json-parse-even-better-errors, wait-on, immutable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
/retest |
|
@Hyperkid123: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
Per Martin this PR is good, so I am merging, mainly to test image mirroring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile.webthat builds all frontend assets in a UBI9 container (no host node/npm required):8085shell/vsplugins/) to prevent filename collisions when merging buildsplugins/management/,plugins/routing/)/api/ui/configat runtime — no hardcoded Keycloak settings/v1/*(gRPC-gateway),/api/ui/*(UI config) — Express mock server removedTest plan
task deploy:devin POC repo builds frontend in container and serves on :8085/v1/deploymentswork🤖 Generated with Claude Code