fleetshift-ui: backend consolidation#78642
fleetshift-ui: backend consolidation#78642Hyperkid123 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughConsolidates CI operator configuration by replacing three separate image targets ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Hyperkid123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@Hyperkid123: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing in favor of #78649 |
Summary
Replace three deleted Dockerfiles with a single
Dockerfile.webin thefleetshift-user-interfacerepo CI config.The UI repo consolidated its build from three separate container images (
fleetshift-gui,fleetshift-mock-servers,fleetshift-mock-ui-plugins) into a singleDockerfile.webthat produces all frontend static assets in one image (fleetshift-web).Removed:
Dockerfile.gui→fleetshift-guiDockerfile.mock-servers→fleetshift-mock-serversDockerfile.mock-ui-plugins→fleetshift-mock-ui-pluginsAdded:
Dockerfile.web→fleetshift-webRelated PR: fleetshift/fleetshift-user-interface#4
Summary by CodeRabbit