Skip to content

fleetshift-ui: backend consolidation#78642

Closed
Hyperkid123 wants to merge 1 commit intoopenshift:mainfrom
Hyperkid123:fleetshift-ui-consolidation
Closed

fleetshift-ui: backend consolidation#78642
Hyperkid123 wants to merge 1 commit intoopenshift:mainfrom
Hyperkid123:fleetshift-ui-consolidation

Conversation

@Hyperkid123
Copy link
Copy Markdown
Contributor

@Hyperkid123 Hyperkid123 commented Apr 30, 2026

Summary

Replace three deleted Dockerfiles with a single Dockerfile.web in the fleetshift-user-interface repo CI config.

The UI repo consolidated its build from three separate container images (fleetshift-gui, fleetshift-mock-servers, fleetshift-mock-ui-plugins) into a single Dockerfile.web that produces all frontend static assets in one image (fleetshift-web).

Removed:

  • Dockerfile.guifleetshift-gui
  • Dockerfile.mock-serversfleetshift-mock-servers
  • Dockerfile.mock-ui-pluginsfleetshift-mock-ui-plugins

Added:

  • Dockerfile.webfleetshift-web

Related PR: fleetshift/fleetshift-user-interface#4

Summary by CodeRabbit

  • Chores
    • Streamlined continuous integration configuration for the user interface build process.
    • Consolidated Docker image building and mirroring to improve build efficiency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 700aa8bb-bb01-49b2-ad34-bee0374f599e

📥 Commits

Reviewing files that changed from the base of the PR and between ba81b88 and d49b6f5.

📒 Files selected for processing (1)
  • ci-operator/config/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main.yaml

Walkthrough

Consolidates CI operator configuration by replacing three separate image targets (fleetshift-gui, fleetshift-mock-servers, fleetshift-mock-ui-plugins) with a single fleetshift-web image built from Dockerfile.web, and simplifies the image-mirroring matrix by removing per-image targets and introducing consolidated mirror entries.

Changes

Cohort / File(s) Summary
CI Operator Image Configuration
ci-operator/config/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main.yaml
Replaced multiple image set definitions with single fleetshift-web image; updated tests image-mirroring matrix to use consolidated pr-image-mirror, pr-merge-image-mirror-latest, and pr-merge-image-mirror-sha entries, removing per-image as targets for PR and postsubmit mirrors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fleetshift-ui: backend consolidation' is vague and does not accurately reflect the actual changes, which are about consolidating UI image configuration (removing multiple image sets and consolidating test image-mirroring matrix). Consider a more specific title that accurately describes the main change, such as 'fleetshift-ui: consolidate image configuration' or 'fleetshift-ui: unify web image builds and mirror targets'.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI/CD configuration files with no Ginkgo test files present. Test names in YAML are static CI job identifiers, not Ginkgo test titles.
Test Structure And Quality ✅ Passed The PR modifies only a YAML CI/CD configuration file, not Go test code. The Ginkgo test quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR contains only YAML CI/CD configuration changes to fleetshift-user-interface image building and test mirroring. No new Ginkgo e2e tests are introduced, making the MicroShift Test Compatibility check inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only CI/operator YAML configuration changes with no new Ginkgo e2e tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed File is CI operator configuration, not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration changes to CI/CD build and test configuration settings, not Go source code or test binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not introduce any new Ginkgo e2e tests. The changes are limited to a single CI operator configuration YAML file that modifies image building and mirroring setup for the fleetshift-user-interface project.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hyperkid123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Hyperkid123: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-fleetshift-fleetshift-user-interface-main-images fleetshift/fleetshift-user-interface presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-user-interface-main-pr-image-mirror-gui fleetshift/fleetshift-user-interface presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-user-interface-main-pr-image-mirror-mock-servers fleetshift/fleetshift-user-interface presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-user-interface-main-pr-image-mirror-mock-ui-plugins fleetshift/fleetshift-user-interface presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@Hyperkid123: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config d49b6f5 link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Hyperkid123
Copy link
Copy Markdown
Contributor Author

Closing in favor of #78649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant