[Snappy] Proximity spacing additional validator#1949
Merged
piotrkluba merged 8 commits intoApr 8, 2026
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
benflexcompute
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Tightens validation by turning an auto-correcting warning into hard
ValueErrors, which can break existing configs that previously passed and were silently clamped. Changes are localized to snappy meshing parameter validation with low runtime risk but potential user-facing validation failures.Overview
Enforces stricter
proximity_spacingvalidation for Snappy refinements.SnappyEntityRefinementnow raises aValueErrorwhenproximity_spacing > min_spacinginstead of logging a warning and mutating the value.Adds default-aware validation for
BodyRefinement. Whenmin_spacingis omitted,SurfaceMeshingParamsnow rejectsBodyRefinement.proximity_spacingvalues that exceeddefaults.min_spacing, and new tests cover both failing and passing cases for these scenarios.Written by Cursor Bugbot for commit a4a4adf. This will update automatically on new commits. Configure here.