[Hotfix Main]: [Snappy] Proximity spacing additional validator#1973
Merged
Conversation
piotrkluba
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1949 (#1949) to the
mainbranch.Hey @piotrkluba, please review this hotfix PR created from your original PR.
Note
Medium Risk
Tightens meshing parameter validation by turning a previous warning/autocorrect into hard errors, which can break existing configs that relied on implicit clamping.
Overview
Strengthens snappy surface meshing refinement validation for
proximity_spacing.SnappyEntityRefinementnow raises a validation error (instead of logging and clamping) whenproximity_spacing > min_spacing.SurfaceMeshingParamsadds an additional check forBodyRefinementthat omitsmin_spacing: it rejectsproximity_spacingvalues that exceeddefaults.min_spacing.Adds focused tests covering the new error and non-error cases.
Reviewed by Cursor Bugbot for commit 36db8ed. Bugbot is set up for automated code reviews on this repo. Configure here.