Skip to content

[Hotfix Main]: [Snappy] Proximity spacing additional validator#1973

Merged
piotrkluba merged 2 commits into
mainfrom
hotfix-main-pr1949
Apr 8, 2026
Merged

[Hotfix Main]: [Snappy] Proximity spacing additional validator#1973
piotrkluba merged 2 commits into
mainfrom
hotfix-main-pr1949

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 8, 2026

Hotfix of PR #1949 (#1949) to the main branch.
Hey @piotrkluba, please review this hotfix PR created from your original PR.

⚠️ Note: This PR had conflicts with the base branch and was resolved automatically. Please review the changes carefully.


Note

Medium Risk
Tightens meshing parameter validation by turning a previous warning/autocorrect into hard errors, which can break existing configs that relied on implicit clamping.

Overview
Strengthens snappy surface meshing refinement validation for proximity_spacing.

SnappyEntityRefinement now raises a validation error (instead of logging and clamping) when proximity_spacing > min_spacing. SurfaceMeshingParams adds an additional check for BodyRefinement that omits min_spacing: it rejects proximity_spacing values that exceed defaults.min_spacing.

Adds focused tests covering the new error and non-error cases.

Reviewed by Cursor Bugbot for commit 36db8ed. Bugbot is set up for automated code reviews on this repo. Configure here.

@piotrkluba piotrkluba marked this pull request as ready for review April 8, 2026 09:07
@piotrkluba piotrkluba enabled auto-merge (squash) April 8, 2026 09:07
@piotrkluba piotrkluba merged commit 172eadb into main Apr 8, 2026
37 checks passed
@piotrkluba piotrkluba deleted the hotfix-main-pr1949 branch April 8, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant