Update all instances of ProfilingSettings to pass at least 1 iter - #1674
Closed
elliottslaughter wants to merge 1 commit into
Closed
Update all instances of ProfilingSettings to pass at least 1 iter#1674elliottslaughter wants to merge 1 commit into
elliottslaughter wants to merge 1 commit into
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously submitted #1657 but then decided to withdraw it. This PR at least updates all instances of
ProfilingSettingsto pass 1 iter, otherwise all of our e2e style tests don't run anything.This could cause some of our tests to become unreliable: some places still use uninitialized data, and if we happen to get
NaNs, can cause the<=checks on loss to fail. However, that is strictly speaking a separate issue.The alternative would be to go back to #1657 and establish data types that enforce a positive number of iterations, but then we lose the ability to shut off execution via
ProfilingSettings.This change is